Revert the hack in Bugzilla->feature and make it more robust

RESOLVED FIXED in Bugzilla 5.0

Status

()

--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: LpSolit, Assigned: LpSolit)

Tracking

Bugzilla 5.0
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 780308 [details] [diff] [review]
patch, v1

Now that we require TT 2.24 on trunk, we no longer have to work around https://rt.cpan.org/Public/Bug/Display.html?id=47929 as it has been fixed in TT 2.23. This makes the code in Bugzilla->feature a bit cleaner and also more robust. Per http://docstore.mik.ua/orelly/perl/cookbook/ch12_03.htm:

"You don't want to use eval { BLOCK }, because this only traps run-time exceptions and use is a compile-time event. Instead, you must use eval "string", to catch compile-time problems as well."

This could explain some bug reports such as bug 897355.
Attachment #780308 - Flags: review?(glob)
Comment on attachment 780308 [details] [diff] [review]
patch, v1

r=glob
Attachment #780308 - Flags: review?(glob) → review+
Flags: approval+
(Assignee)

Comment 2

5 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla.pm
Committed revision 8665.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.