897464 - /js/frame/restart/states/setuptest_skip.js fails with "Only setupModule ran prior to teardownTest so state is 1 - '3' should equal '1'"

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Andreea Matei [:AndreeaMatei]]

I see this on OS X and Linux, here you can find a console log:
http://pastebin.mozilla.org/2700181

I ran it with Nightly.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It's because there are two tests and we run teardownTest twice. So the second time the value will be 3 and the check will fail.

Anyone who wants to fix that?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ideally all those tests should have been a python tests. Andreea, can you please file a mentored bug so we can get those transferred?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

Does this patch fix it for you? I don't see the failure anymore.

Comment 4

[Andrei Eftimie]

Comment on attachment 781052 [details] [diff] [review]
Patch v1

Review of attachment 781052 [details] [diff] [review]:
-----------------------------------------------------------------

This fixes the problem for me.
The tests are passing now.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 781052 [details] [diff] [review]
Patch v1

Review of attachment 781052 [details] [diff] [review]:
-----------------------------------------------------------------

As mentioned by Andreea on IRC the test is passing for her now.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
https://github.com/mozilla/mozmill/commit/c8291bdbd8be847551de251bce2a0f548058d0cc

Andreea, please file a new bug to get this test moved to a pyhton test. Thanks.

Comment 7

[Andreea Matei [:AndreeaMatei]]

Filed bug 898374 for it, just have to check what's covered there.