Closed
Bug 897484
Opened 7 years ago
Closed 7 years ago
GC: Convert JS_GetProperty APIs to take MutableHandleValue
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: jonco, Assigned: jonco)
References
Details
(Keywords: dev-doc-complete)
Attachments
(3 files)
|
30.06 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
|
18.75 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
|
49.30 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Following on from bug 896540, we can convert JS_GetProperty and related APIs to take MutableHandleValue rather than jsval* for the out parameter.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #780946 -
Flags: review?(terrence)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #780947 -
Flags: review?(bobbyholley+bmo)
|
|
Assignee | |
Comment 3•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Attachment #780948 -
Flags: review?(bugs)
|
||
Updated•7 years ago
|
Attachment #780947 -
Flags: review?(bobbyholley+bmo) → review+
|
||
Comment 4•7 years ago
|
||
Comment on attachment 780946 [details] [diff] [review] 1 - changes in JS engine Review of attachment 780946 [details] [diff] [review]: ----------------------------------------------------------------- Righteous! r=me
Attachment #780946 -
Flags: review?(terrence) → review+
|
||
Comment 5•7 years ago
|
||
Comment on attachment 780948 [details] [diff] [review] 3 - changes in the browser Ah in @@ -7386,31 +7386,31 @@ class CGDOMJSProxyHandler_get(ClassMetho vp is already MutableHandle
Attachment #780948 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae8d72538dee
|
||
Comment 7•7 years ago
|
||
seems this caused this bustage https://tbpl.mozilla.org/php/getParsedLog.php?id=25766524&tree=Mozilla-Inbound backed this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/0621ef3a01da
|
|
Assignee | |
Comment 8•7 years ago
|
||
Fixed and re-landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/e80edaac3899
|
||
Comment 9•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e80edaac3899 https://hg.mozilla.org/mozilla-central/rev/2e2955849611
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
|
|
Assignee | |
Updated•7 years ago
|
Blocks: 773686
Keywords: dev-doc-needed
|
||
Comment 10•5 years ago
|
||
Docs updated by :arai :) https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_GetProperty Technical review appreciated.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•