GC: Convert JS_GetProperty APIs to take MutableHandleValue

RESOLVED FIXED in mozilla25

Status

()

RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

({dev-doc-complete})

unspecified
mozilla25
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Following on from bug 896540, we can convert JS_GetProperty and related APIs to take MutableHandleValue rather than jsval* for the out parameter.
Created attachment 780946 [details] [diff] [review]
1 - changes in JS engine
Attachment #780946 - Flags: review?(terrence)
Created attachment 780947 [details] [diff] [review]
2 - changes in XPConnect
Attachment #780947 - Flags: review?(bobbyholley+bmo)
Created attachment 780948 [details] [diff] [review]
3 - changes in the browser
Attachment #780948 - Flags: review?(bugs)
Attachment #780947 - Flags: review?(bobbyholley+bmo) → review+
Comment on attachment 780946 [details] [diff] [review]
1 - changes in JS engine

Review of attachment 780946 [details] [diff] [review]:
-----------------------------------------------------------------

Righteous! r=me
Attachment #780946 - Flags: review?(terrence) → review+
Comment on attachment 780948 [details] [diff] [review]
3 - changes in the browser

Ah in  @@ -7386,31 +7386,31 @@ class CGDOMJSProxyHandler_get(ClassMetho
vp is already MutableHandle
Attachment #780948 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/e80edaac3899
https://hg.mozilla.org/mozilla-central/rev/2e2955849611
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Blocks: 773686
Keywords: dev-doc-needed
Docs updated by :arai :)

https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_GetProperty

Technical review appreciated.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.