Closed Bug 897484 Opened 7 years ago Closed 7 years ago

GC: Convert JS_GetProperty APIs to take MutableHandleValue

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: jonco, Assigned: jonco)

References

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

Following on from bug 896540, we can convert JS_GetProperty and related APIs to take MutableHandleValue rather than jsval* for the out parameter.
Attachment #780946 - Flags: review?(terrence)
Attachment #780947 - Flags: review?(bobbyholley+bmo)
Attachment #780948 - Flags: review?(bugs)
Attachment #780947 - Flags: review?(bobbyholley+bmo) → review+
Comment on attachment 780946 [details] [diff] [review]
1 - changes in JS engine

Review of attachment 780946 [details] [diff] [review]:
-----------------------------------------------------------------

Righteous! r=me
Attachment #780946 - Flags: review?(terrence) → review+
Comment on attachment 780948 [details] [diff] [review]
3 - changes in the browser

Ah in  @@ -7386,31 +7386,31 @@ class CGDOMJSProxyHandler_get(ClassMetho
vp is already MutableHandle
Attachment #780948 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/e80edaac3899
https://hg.mozilla.org/mozilla-central/rev/2e2955849611
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Blocks: 773686
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.