897484 - GC: Convert JS_GetProperty APIs to take MutableHandleValue

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Following on from bug 896540, we can convert JS_GetProperty and related APIs to take MutableHandleValue rather than jsval* for the out parameter.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: 1 - changes in JS engine

Comment 2

[Jon Coppeard (:jonco)]

Attachment: 2 - changes in XPConnect

Comment 3

[Jon Coppeard (:jonco)]

Attachment: 3 - changes in the browser

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 780946 [details] [diff] [review]
1 - changes in JS engine

Review of attachment 780946 [details] [diff] [review]:
-----------------------------------------------------------------

Righteous! r=me

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 780948 [details] [diff] [review]
3 - changes in the browser

Ah in  @@ -7386,31 +7386,31 @@ class CGDOMJSProxyHandler_get(ClassMetho
vp is already MutableHandle

Comment 6

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae8d72538dee

Comment 7

[Carsten Book [:Tomcat]]

seems this caused this bustage https://tbpl.mozilla.org/php/getParsedLog.php?id=25766524&tree=Mozilla-Inbound 

backed this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/0621ef3a01da

Comment 8

[Jon Coppeard (:jonco)]

Fixed and re-landed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e80edaac3899

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e80edaac3899
https://hg.mozilla.org/mozilla-central/rev/2e2955849611

Comment 10

[Florian Scholz (Open Web Docs)]

Docs updated by :arai :)

https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_GetProperty

Technical review appreciated.