897539 - uninline ProtocolErrorBreakpoint to avoid code and string bloat

Status: RESOLVED FIXED

(Core :: IPC, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: uninline ProtocolErrorBreakpoint to avoid code and string bloat

Having this error-only function inlined causes code bloat.  The string
argument to printf_stderr also gets duplicated in all files where
ProtocolErrorBreakpoint is called.

I see ~7k code size reduction over ipc/ipdl/*.o from this change,
according to size(1).  Curiously, I don't see any data size reduction
from this according to size(1), but I verified that the string section
for one of the .o files *is* smaller (~25 bytes * ~170 files, so another
3k or so in savings), so it's possible size(1) is not a reliable guide
here.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6d171bc59674