897571 - [Fig] Urlbar resize for entry is incorrectly rendered

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Description

[Chenxia Liu [:liuche]]

Attachment: Screenshot: urlbar resize

On the HTC One V running Android 4.0.3, urlbar resize doesn't refresh the images correctly. (This looks fine on the Galaxy Nexus running 4.2.2 and the Nexus S running 2.3.4.)

Can someone try to repro on some other 4.0 phones?

Comment 1

[Lucas Rocha (:lucasr)]

Chenxia, can you still reproduce? I couldn't...

Comment 2

[Lucas Rocha (:lucasr)]

Marking as p1, looks serious (if it's easily reproducible on some devices)

Comment 3

[Chenxia Liu [:liuche]]

I just updated to the latest fig nightly (8/13) and I still see this.

The device is my personal phone, HTC One V, running 4.0.3. I can't seem to find any other 4.0.3 non-tablets to check on.

QA: can you try to verify on different 4.0.3 phones?

Comment 4

[Chenxia Liu [:liuche]]

I just tried this out on a Motorola 4.0.4 phone, and couldn't repro it.

Comment 5

[Teodora Vermesan (:TeoVermesan)]

I cannot reproduce this on Samsung Galaxy Tab (Android 4.0.4) on latest fig nightly.

Comment 6

[Lucas Rocha (:lucasr)]

Hey Aaron, do you have any device with Android 4.0.3 to try this?

Comment 7

[Aaron Train [:aaronmt]]

Attachment: Fig Nightly (08/14)

Reproducible on the first Android 4.0.4 I picked up. Alcatel One Touch 997.

Comment 8

[Aaron Train [:aaronmt]]

Landscape orientation is unaffected.

Comment 9

[Chenxia Liu [:liuche]]

Attachment: Patch: fix clipping by increasing to 60%

The problem seems to have been that the urlbar that is clipped for the right side is too small - I increased the hard-coded value to 60%.

AaronMT: Can you verify that this build fixes the problem on your device?
http://people.mozilla.org/~liuche/bug-897571/

Comment 10

[Aaron Train [:aaronmt]]

Sure. I won't have access to the device until Wednesday. Was anyone else reading this able to reproduce that can take a look?

Comment 11

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 801935 [details] [diff] [review]
Patch: fix clipping by increasing to 60%

Review of attachment 801935 [details] [diff] [review]:
-----------------------------------------------------------------

:P

Comment 12

[Chenxia Liu [:liuche]]

Aaron: I was able to verify this fix on my HTC One V, but I'd like to see the fix working on other devices before landing it.

Comment 13

[Lucas Rocha (:lucasr)]

(In reply to Chenxia Liu [:liuche] from comment #9)
> Created attachment 801935 [details] [diff] [review]
> Patch: fix clipping by increasing to 60%
> 
> The problem seems to have been that the urlbar that is clipped for the right
> side is too small - I increased the hard-coded value to 60%.

Nice catch :-)

Comment 14

[Aaron Train [:aaronmt]]

Sorry for the delay. Yes, the above patch and custom build resolves this on my reproducible device.

Land it!

Comment 15

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/906d83601f14

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/906d83601f14