Closed Bug 897573 Opened 10 years ago Closed 10 years ago

Get rid of the make rules from toolkit/components/osfile/Makefile.in

Categories

(Toolkit Graveyard :: Build Config, defect)

Product:
Toolkit Graveyard
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla25

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Patch v1
6.13 KB, patch
glandium
: review+
Details | Diff | Splinter Review
Attached patch Patch v1 — — Splinter Review 
      No description provided.
Attachment #780501 - Flags: review?(mh+mozilla)
Comment on attachment 780501 [details] [diff] [review]
Patch v1

Review of attachment 780501 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you don't move the files at the same time. There's no reason to add another directory to traverse.
Attachment #780501 - Flags: review?(mh+mozilla) → review+
Comment on attachment 780501 [details] [diff] [review]
Patch v1

toolkit/components/osfile/moz.build already installs osfile.jsm to modules/, so I don't think I can install to modules/osfile from the same dir (yet).
Attachment #780501 - Flags: review+ → review?(mh+mozilla)
Comment on attachment 780501 [details] [diff] [review]
Patch v1

Review of attachment 780501 [details] [diff] [review]:
-----------------------------------------------------------------

I see

::: toolkit/components/osfile/moz.build
@@ +5,5 @@
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +DIRS += [
> +    'modules',
> +]

You can put that on one line if you prefer.
Attachment #780501 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/5423e04326c2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.