897573 - Get rid of the make rules from toolkit/components/osfile/Makefile.in

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 780501 [details] [diff] [review]
Patch v1

Review of attachment 780501 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you don't move the files at the same time. There's no reason to add another directory to traverse.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 780501 [details] [diff] [review]
Patch v1

toolkit/components/osfile/moz.build already installs osfile.jsm to modules/, so I don't think I can install to modules/osfile from the same dir (yet).

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 780501 [details] [diff] [review]
Patch v1

Review of attachment 780501 [details] [diff] [review]:
-----------------------------------------------------------------

I see

::: toolkit/components/osfile/moz.build
@@ +5,5 @@
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +DIRS += [
> +    'modules',
> +]

You can put that on one line if you prefer.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/5423e04326c2