897614 - Cache IDs of widgets that we cannot find with findWidgetInWindow to fast-path searching in later windows

Status: RESOLVED WONTFIX

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

If we search for a widget, and we cannot find it in a window, we can cache the fact that we missed it and shortcut for future windows. We remove items from this cache when they get created by createWidget.

We might need to special-case Private Browsing windows (since we've made it so that some widgets cannot appear in PB windows). But I've pushed a patch that does the above just to see if it gets us any tpaint wins.

https://tbpl.mozilla.org/?tree=Try&rev=f8b3573f328a

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Base build for reference: https://tbpl.mozilla.org/?tree=Try&rev=4a16fe238fcf

Comment 2

[Dão Gottwald [:dao]]

(In reply to Mike Conley (:mconley) from comment #0)
> We remove items from this cache when they get created by createWidget.

That's not the only way to create customizable items, is it? For instance, elements could be appended to the palette, couldn't they?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(In reply to Dão Gottwald [:dao] from comment #2)
> (In reply to Mike Conley (:mconley) from comment #0)
> > We remove items from this cache when they get created by createWidget.
> 
> That's not the only way to create customizable items, is it? For instance,
> elements could be appended to the palette, couldn't they?

I suppose - and we can address this case if it turns out that this patch gains us anything.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

So this patch's results can be see in row 143 of the spreadsheet.

https://docs.google.com/a/mozilla.com/spreadsheet/ccc?key=0Asj8iLTl0K0UdDcxemJEWVVXWTlKek1wR09iS2FsOXc#gid=0

While it's possible that we saw a little bit of win here amongst the noise, it's not moving the needle where it counts (XP tpaint).  :/

Comment 5

[Mike Conley (:mconley) (:⚙️)]

I'm trying this idea again in conjuction with a patch that puts the a spring into the toolbar-menubar in bug 902632.

Comment 6

[:Gijs (he/him)]

More WONTFIX fodder, Mike?

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Indeed!