897650 - Build Teach-templates overview page

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Cassie McDaniel [:cassiemc]]

This page isn't designed yet. That's being tracked in bug 897648

Comment 1

[Matt Thompson (@OpenMatt :OpenMatt)]

* This page is now designed, I believe. as per bug 897648

* can we go ahead and build the page?

Comment 2

[Cassie McDaniel [:cassiemc]]

Yes, this page is ready to go as per designs in bug 897648. Dale, assets are on Google Drive and in production / images. Let me know if you need anything else!

Comment 3

[Cassie McDaniel [:cassiemc]]

Matt, can you confirm where the links in the comp should point to?

* Top tips
* Teaching kit template > get started button
* Activity template > get started button

Comment 4

[Matt Thompson (@OpenMatt :OpenMatt)]

Top tips:
https://support.mozilla.org/en-US/kb/top-tips-creating-great-teaching-kits

* Teaching kit template > get started button
https://thimble.webmaker.org/project/10274/remix

* Activity > get started
https://thimble.webmaker.org/project/10286/remix

Comment 5

[Matt Thompson (@OpenMatt :OpenMatt)]

Cassie: check out https://blog.webmaker.org/teaching_kit

Let me know if you have suggestions for improving the language or landing pages?
This new overview page will definitely help with user experience for people creating kits.

Comment 6

[Dale Karp (:daleee)]

Attachment: Code Review

https://github.com/mozilla/webmaker.org/pull/353

Comment 7

[Dale Karp (:daleee)]

Attachment: Design Review

http://dk-webmaker.herokuapp.com/teach-templates

Comment 8

[inactivate account for kate]

Comment on attachment 800736 [details]
Design Review

Design review:

* For mobile, try making everything fit to 100% and removing the corner banner (http://dl.dropbox.com/u/29163874/Screenshots/lo.png)

* Need help box needs more padding + line height + border radius
http://dl.dropbox.com/u/29163874/Screenshots/lp.png

* Use open-sans-light for h2 and h3 ("Teaching Kit", "Create a lesson plan")

* Reduce the space at the bottom of the "Get started" button to about 30px (http://dl.dropbox.com/u/29163874/Screenshots/lr.png)

Comment 9

[Dale Karp (:daleee)]

Attachment: Design Review II

http://dk-webmaker.herokuapp.com/teach-templates

Comment 10

[inactivate account for kate]

Comment on attachment 800732 [details] [review]
Code Review

A few things to fix, please fix lint errors as well

Comment 11

[Dale Karp (:daleee)]

Attachment: Code Review II

https://github.com/mozilla/webmaker.org/pull/353

Comment 12

[inactivate account for kate]

Comment on attachment 800880 [details] [review]
Code Review II

This is fine now but set height to auto on those columns for mobile

Comment 13

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/3382e0da57d3b31178e3cdaddacdac3af5739a6f
[bug 897650] Build Teach Templates page

https://github.com/mozilla/webmaker.org/commit/7e1f1536ed0b2264425442c0c95236fe9dc846ff
Merge pull request #353 from daleee/897650-teach-templates

[bug 897650] Build Teach Templates page