Building with VS2012 causes "STL code can only be used with infallible ::operator new()" error in maintenanceservice

RESOLVED FIXED in mozilla25

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: nrc, Assigned: mbrubeck)

Tracking

unspecified
mozilla25
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Recent build regression.

I couldn't figure out what regressed this because all the relevant looking bugs are security bugs that I couldn't see.
Seems to me toolkit/components/maintenanceservice/Makefile.in should have STL_FLAGS=
Posted patch stl-fixup (obsolete) — Splinter Review
I tested glandium's proposed fix and it worked.
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #780693 - Flags: review?(gps)
Comment on attachment 780693 [details] [diff] [review]
stl-fixup

Review of attachment 780693 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/maintenanceservice/Makefile.in
@@ +11,5 @@
>  
>  # For debugging purposes only
>  #DEFINES += -DDISABLE_UPDATER_AUTHENTICODE_CHECK
>  
> +STL_FLAGS=

Please move it so that it is together with MOZ_GLUE_LDFLAGS and  MOZ_GLUE_PROGRAM_LDFLAGS.
Posted patch patch v2 (obsolete) — Splinter Review
Addresses Glandium's comment.
Attachment #780693 - Attachment is obsolete: true
Attachment #780693 - Flags: review?(gps)
Attachment #781018 - Flags: review?(gps)
This patches works for me only if I disable the maintenance service. :/
Hm. When I run a clobber build with this patch applied, I get:

"export_tier_nspr
No makefile found"

and then error 2.

In order to make this work, I have to clobber and build once without the patch (which fails as usual on the maintenance service issues), and then build a second time without clobber with the patch applied. :/
(In reply to Nick Cameron [:nrc] from comment #0)
> Recent build regression.
> 
> I couldn't figure out what regressed this because all the relevant looking
> bugs are security bugs that I couldn't see.

I tried backing out and building w/o recent sec bug changes, but this still happens.
I haven't built with the supplied patch by the way.
Clean build works for me with patch applied with vs2012, I think we should land this.
(In reply to Jonathan Wilde [:jwilde] from comment #6)
> Hm. When I run a clobber build with this patch applied, I get:
> 
> "export_tier_nspr
> No makefile found"

I couldn't reproduce this.  My clobber build with this patch succeeded.
Duplicate of this bug: 898454
Repulled and started another clobber build with the patch applied. I'm not running into the export_tier_nspr issues anymore.
This seems to have fixed the issue. With patch applied the error doesnt come up anymore
Attachment #781018 - Flags: review?(gps) → review+
Attachment #781018 - Attachment is obsolete: true
Attachment #782029 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7a41eacda2cb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.