897786 - [Buri][Contacts]The contact pic display abnormal when link contact with Gmail and facebook

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.164
 Firefox os  v1.1
 Mozilla build ID:20130715070218
 
 
 
 Created an attachment (id=468762)
 pic
 
 DEFECT DESCRIPTION:
  The pic was not the same
  REPRODUCING PROCEDURES:
  1.Log in Gmail,import a contact A which have head portrait
  2.Edit this contact,Link contact,Select a Facebook Friend which have a different head portrait
  3.Back to Contacts,The contact A displayed Gmail's contact pic
  4.Edit this contact,it displayed the Gmail's contact pic
  5.Close the Contacts progress,Launch Contacts again
  6.The Contact A head portrait was changed---->KO
  EXPECTED BEHAVIOUR:
  The pic should stay the same
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
  Mid 
  REPRODUCING RATE:
  5/5
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Attachment: pic

Comment 2

[sync-1]

Clone from brother

Comment 3

[sync-1]

Attachment: pic

Comment 4

[sync-1]

Attachment: pic_2

Comment 5

[buri.blff]

this is block pr.please update status,thanks.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Is this a regression from v1.0.1?

Comment 7

[Natalya Kot [:nkot]]

the same behavior is observed on v1.0.1 (if I understand the issue correctly)

 1. the user creates a contact with picture (no option to import from gmail on v1.0.1)
 2. the user links this contact to a Facebook contact
  ==> the contact has original picture in contact details and in Contacts list
 3. the user restarts Contacts app
  ==> the contact has now Facebook picture in Contacts list,
      there is still original picture in contact details, though it appears zoomed in a little

Build ID: 20130525070214
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9ce68012f9da
Gaia: 26d9430df4cd670e46a208a6e4b6d77e4b27ed75
Platform Version: 18.0

Comment 8

[Jose Manuel Cantera]

Attachment: Pointer to GH PR ##11245

Comment 9

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 783027 [details]
Pointer to GH PR ##11245

Looks good!  I posted a few minor nits in the pull request.  I also had a concern about how we handle the case where the local photo is deleted after the FB data is loaded, but I think that will be ok due to the way the list refresh() is implemented.  Thanks!  r+

Comment 10

[bhavana bajaj [:bajaj]]

Given comment #7, looks like it is not a regression and this can be resolved in future release.

Comment 11

[Jose Manuel Cantera]

yes, fixed in master and should be available for Koi. 

https://github.com/mozilla-b2g/gaia/commit/26a853cc03a54ac2341c7b7d6c386d58670f75eb

Comment 12

[buri.blff]

Dear jmcf:
   can you merge the patch to v1.1?

Comment 13

[Jose Manuel Cantera]

Sorry, if it is not marked as leo it cannot be uplifted

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

if you want it to be in v1.1, please change it to leo?

Comment 15

[Jack Liu]

Yes, it should be in v1.1, thanks.

Comment 16

[buri.blff]

Dear Joe,
please merge the patch to v1.1,thanks.

Comment 17

[Alex Keybl [:akeybl]]

This is not a regression, so this is not a blocker and therefore cannot land to 1.1. This will be fixed for the first time in 1.2.

Please see email sent to [e-mail] (all partners) about blocking criteria. Thanks!

Comment 18

[buri.blff]

(In reply to Alex Keybl [:akeybl] from comment #17)
> This is not a regression, so this is not a blocker and therefore cannot land
> to 1.1. This will be fixed for the first time in 1.2.
> 
> Please see email sent to [e-mail] (all partners)
> about blocking criteria. Thanks!

this will affect user experience. What we need is a product not a toy.
we can do better, why we don't do?