Closed Bug 897891 Opened 11 years ago Closed 11 years ago

Add 'geo.provider.testing' preference to stop OS level sharing dialog on OS X

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: AndreeaMatei, Assigned: whimboo)

References

Details

(Whiteboard: [mozmill-2.0][mozmill=1.5.22+][ateamtrack: p=mozmill q=2013q3 m=2])

Attachments

(2 files)

Patch v1
1.11 KB, patch
k0scist
: review+
Details | Diff | Splinter Review
Patch v1
5.98 KB, patch
k0scist
: review+
Details | Diff | Splinter Review 
This is needed for bug 758187 where opening the following page on OS X and clicking the 'Share location' button, the system pops up a dialog to allow Nightly to share the location.

http://www.mozqa.com/data/firefox/geolocation/position.html

This would be needed in 1.5 and 2.0 as well.
should this be a mozmill bug?
In bug 758187 comment 94 it was suggested this may apply to mozbase. Don't we have a shared location for such preferences, or are you suggesting this preference would only ever apply to Mozmill tests?
Flags: needinfo?(jhammel)
As for now all preferences are set in mozprofile so they are shared across all mozbase apps. This is not ideal and will be changed in the future. But until now this work hasn't happened. So mozbase should still be the right component here. Only for Mozmill 1.5 it will directly land in the mozmill repository.
Flags: needinfo?(jhammel)
OS: Linux → Mac OS X
Hardware: x86_64 → All
Summary: Add "geo.provider.testing" preference in Mozmill in order to allow location sharing → Add 'geo.provider.testing' preference to stop OS level sharing dialog on OS X
Attached patch Patch v1 — — Splinter Review 
Assignee: nobody → hskupin
Status: NEW → ASSIGNED

        Attachment #789140 -
        Flags: review?(jhammel)

    
    

    
  
Comment on attachment 789140 [details] [diff] [review]
Patch v1

lgtm

        Attachment #789140 -
        Flags: review?(jhammel) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v1
        — 
          — Splinter Review
      

    


  
Patch for Mozmill 1.5. Sorry for the whitespace changes but sublime decided to do those all on its own.

        Attachment #790436 -
        Flags: review?(jhammel)

    
  

        Attachment #790436 -
        Flags: review?(jhammel) → review+

    
    

    
  
Landed in the mozmill repository for mozrunner 2.5.15:
https://github.com/mozilla/mozmill/commit/f7040a07a05a8666017ecc89ceeeb6dc1dbd459e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [mozmill-2.0][mozmill=1.5.22?] → [mozmill-2.0][mozmill=1.5.22][ateamtrack: p=mozmill q=2013q3 m=2]
Whiteboard: [mozmill-2.0][mozmill=1.5.22][ateamtrack: p=mozmill q=2013q3 m=2] → [mozmill-2.0][mozmill=1.5.22+][ateamtrack: p=mozmill q=2013q3 m=2]
Blocks: 907983

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: