897916 - HD: browser resources need update

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[[e-mail]]

Attachment: device-2013-07-25-174939.png

* close sign(x) is smaller than arrow, and is a bit thin (not square as 1x image)

* lack of 1.5x share icon (apps/browser/style/images/share.png)


refer to http://gasolin.github.io/gaia/browser.html

Comment 1

[[e-mail]]

@amy please help provide related resources, thanks

Comment 2

[[e-mail]]

Attachment: device-2013-07-25-175127.png

look closely we find 'back' icon is bigger, 
and color is not the same as top bar.
It also lost the 'top write' line detail

Comment 3

[[e-mail]]

also please help confirm for 1.5x image consistency (if its intended)

apps/browser/style/images/site_security_broken.png
apps/browser/style/images/progress.png
apps/browser/style/images/iconaction_back_50x50.png

Comment 4

[Amy Lee [:amylee] UX]

Attachment: Browser_Assets.zip

Hi Fred 

Here are my comments:

The close sign is correct. This is what we are using universally for close/cancel functions. The arrow looks blurry. Have you replaced it with the new browser assets? I have included the arrow for your convenience.

site_security_broken.png - correct
progress.png - correct (this should be universally the same across apps)
iconaction_back_50x50 - this is incorrect, I have attached the correct one

I will need to get back to you about the tabs. It seems there is inconsistencies with the colouring of the tabs compared to what was submitted for @1 scale.

Thanks

Comment 5

[Amy Lee [:amylee] UX]

Attachment: New_Tabs.zip

Hi, 

Attached are new tab, top header, and tab background. Please use these to replacement what is currently in the build.

Thanks!

Comment 6

[Amy Lee [:amylee] UX]

Hi 

Sorry please disregard my last message. I will send over another set of updated graphics.

Comment 7

[Amy Lee [:amylee] UX]

Attachment: New_Tabs_v2.zip

Hi, 

Attached are a new set of graphics (tab, top header, tab background) to replace the current ones.

Comment 8

[Wayne Chang [:wchang]]

HD+ asset bug

Comment 10

[[e-mail]]

Attachment: PR for browser assets

PR for asset replacement only

Comment 11

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 781513 [details]
PR for browser assets

r=me

thanks for your patch!

Comment 12

[[e-mail]]

merged to master-gaia https://github.com/mozilla-b2g/gaia/commit/88fb4e4a0aa1aeeee0a39bfea0399751a839a2fc

thanks!

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Do we still need hd patch on this bug?

Comment 15

[[e-mail]]

Yes, we need uplift it to hd

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Not landed on v1-train. Resetting status-b2g18.

Comment 17

[[e-mail]]

merged to 1.1.0hd
https://github.com/mozilla-b2g/gaia/commit/6d5e08e2273a7bbae96d0a29777773acf846764a

Comment 18

[Eric Pang [:epang] UX]

Fred, Amy and I are still noticing that the header is still not fitting together correctly, see link. (btw the back arrow is being fixed by another bug already 906630)

http://cl.ly/image/2X3s2r030H3I

Should this bug be reopened?  Or are we looking at an outdated screen?

Thanks!
Eric

Comment 19

[Eric Pang [:epang] UX]

Attachment: topsite,history,bookmarks (tabs).png

Hi, I also noticed that the top sites, bookmarks, history tabs are now in line (height wise) but the the curved sides still do not match the center in color.  Fred can you take a look and let me or Amy know if any new assets are needed? Thanks!

Comment 20

[[e-mail]]

Attachment: v1.1.0hd_8_23_browser_screenshot

left arrow seems fixed in current branch.

Comment 21

[[e-mail]]

spot the tab color issue, will reopen bug 897917 to fix it

Comment 22

[Al Tsai [:atsai]]

[2013/10/21 Helix Testing]
Gaia:     c829a2042594b6c3a4899ee27979799a0f301534
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019
BuildID   20131015042201
Version   18.0