897930 - Unhide hidden preference for disabling green download flash animation added in bug #861613

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, enhancement)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

There is no logical base to hide any preferences in about:config from advanced users as only advanced users use about:config.
The only users who were added to bug #861613 CC list know about his feature.
There is no information on this preference even on http://dxr.mozilla.org/
So please don't hide any preferences as it's only pains users to waste time for searching web and ask questions on support forums.

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Adding "regression" to keywords as now you can't disable animation you didn't have before

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

When bug 861613 first landed the first thing I did was ask around, and read the patch to uncover the 'hidden' pref. 


I totally agree, the pref should be un-hidden. 

Setting to NEW

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

no, it doesn't satisfy our regression definition, the animations are intended by design. Still a valid enh request though.
We don't have resources to work on this at the moment, but will gladly accept patches, should be as easy as adding the pref and a brief comment to http://mxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js close to the other browser.download. prefs

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 780971 [details] [diff] [review]
patch

Review of attachment 780971 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +332,5 @@
>  
>  // This allows disabling the Downloads Panel in favor of the old interface.
>  pref("browser.download.useToolkitUI", false);
>  
> +// This allows disabling visual notifications of Downloads Indicator

// This allows disabling the animated notifications shown by
// the Downloads Indicator when a download starts or completes.

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

(In reply to Marco Bonardo [:mak] from comment #5)
> Comment on attachment 780971 [details] [diff] [review]
> patch
> 
> Review of attachment 780971 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/app/profile/firefox.js
> @@ +332,5 @@
> >  
> >  // This allows disabling the Downloads Panel in favor of the old interface.
> >  pref("browser.download.useToolkitUI", false);
> >  
> > +// This allows disabling visual notifications of Downloads Indicator
> 
> // This allows disabling the animated notifications shown by
> // the Downloads Indicator when a download starts or completes.

What should I do? Should I submit a new patch with your clearer comment or just mark this bug "checkin-needed"?

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Xidorn Quan from comment #6)
> What should I do? Should I submit a new patch with your clearer comment or
> just mark this bug "checkin-needed"?

you should submit a new patch with the changed comment, the r=mak in the commit message, and then mark checkin-needed

Comment 8

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch

Comment 9

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/f5c294e75e01

Comment 10

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

If I can I would like to request pushing this patch also for Firefox 24, so it will be easier to disable this download animation landed bug #861613.
Thanks!

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

sorry, but it doesn't satisfy our uplift requirements.

Comment 12

[Matthew N. [:MattN]]

https://hg.mozilla.org/mozilla-central/rev/f5c294e75e01