Closed Bug 897969 Opened 7 years ago Closed 5 years ago

Support `origin` manifest property when pushing an app to the device

Categories

(DevTools :: WebIDE, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

(Whiteboard: [leave-open])

Attachments

(2 files, 2 obsolete files)

For now, when pushing an app to the device or installing it on the simulator, `origin` manifest property is being ignored.

We should tweak the webapps actor to take care of this new attribute introduced in bug 852720.
Assignee: nobody → poirot.alex
Based on top of bug 912475, that depends on bug 914604.
Attachment #803018 - Attachment is obsolete: true
Unfortunately, this test still fails on b2g because of the test domain,
which is mochi.test:8888 and I have issues making such custom origin to work.
So there is still some work needed for the test in order to use a domain without port.
Attachment #803649 - Flags: review?(fabrice)
Comment on attachment 803649 [details] [diff] [review]
Support `origin` manifest property when pushing an app to the device r=fabrice

Review of attachment 803649 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #803649 - Flags: review?(fabrice) → review+
Attachment #805062 - Flags: review+
Note for checkin, it needs to be landed after bug 914604 and 912475, which are also ready to land.
Keywords: checkin-needed
Marking [leave-open] as the test hasn't landed yet:

https://hg.mozilla.org/integration/fx-team/rev/73c2063e2ab7
Status: NEW → ASSIGNED
Flags: in-testsuite?
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team][leave-open]
https://hg.mozilla.org/mozilla-central/rev/73c2063e2ab7
Whiteboard: [fixed-in-fx-team][leave-open] → [leave-open]
Priority: -- → P3
Alex, maybe this bug should be closed and another opened for just the test, since the functionality has at least landed?
Flags: needinfo?(poirot.alex)
Depends on: 1098447
Sure.
Flags: needinfo?(poirot.alex)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.