897969 - Support `origin` manifest property when pushing an app to the device

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

For now, when pushing an app to the device or installing it on the simulator, `origin` manifest property is being ignored.

We should tweak the webapps actor to take care of this new attribute introduced in bug 852720.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Support `origin` manifest property when pushing an app to the device r=fabrice

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Support `origin` manifest property when pushing an app to the device r=fabrice

Based on top of bug 912475, that depends on bug 914604.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: mochitest for origin manifest property

Unfortunately, this test still fails on b2g because of the test domain,
which is mochi.test:8888 and I have issues making such custom origin to work.
So there is still some work needed for the test in order to use a domain without port.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 803649 [details] [diff] [review]
Support `origin` manifest property when pushing an app to the device r=fabrice

Review of attachment 803649 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Rebased

https://tbpl.mozilla.org/?tree=Try&rev=15ff30fdcf58

Comment 6

[Alexandre Poirot [:ochameau]]

Note for checkin, it needs to be landed after bug 914604 and 912475, which are also ready to land.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Marking [leave-open] as the test hasn't landed yet:

https://hg.mozilla.org/integration/fx-team/rev/73c2063e2ab7

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/73c2063e2ab7

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Alex, maybe this bug should be closed and another opened for just the test, since the functionality has at least landed?

Comment 10

[Alexandre Poirot [:ochameau]]

Sure.