898000 - Add getIconAsDataURL in webapps actor

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Alexandre Poirot [:ochameau]]

In order to help fetching various device contents like app icon, manifest,...
we would need a way to fetch these content from the remote to the client as they are accessible via URL that only works on the remote, like app://.../manifest.webapp.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Add a url resolver actor

I haven't added the actor to the browser actor list
in order to only load it when we will start using it.

That's so nice to do such feature without using any chrome/xpcom \o/

Comment 2

[Paul Rouget [:paul]]

What about registering the actor in shell.js?

Comment 3

[Paul Rouget [:paul]]

When I resolve:

"app://settings.gaiamobile.org/style/icons/60/Settings.png"

the mimetype is application/xml

Comment 4

[Paul Rouget [:paul]]

How do we handle 404?

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

I still don't see this as a clean way to do things. It brings back memories of RPC.

In the current design, actors are entities with meaningful lifetimes and a related client that communicates with them through a collection of requests that operate on their state. For instance, the tab actor is responsible for intermediating with the remote tab and has methods that the tab client can use to manipulate the state of the tab, such as reload, navigateTo, etc.

This new actor is only capable of making stateless requests on behalf of various clients that could presumably grow a similar capability, if not return the data as part of other responses. For example, a hypothetical webapp actor could respond to an "icon" request, or even return the icon in the response of an "info" or "attach" request.

Comment 7

[Paul Rouget [:paul]]

Comment on attachment 781026 [details] [diff] [review]
Add a url resolver actor

I talked to Panos. We need to move this at the app actor level. We should implement a `getIconAsDataURL()` method. Sorry :)

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: Add getIconAsDataURL in webapps actor

Comment 9

[Alexandre Poirot [:ochameau]]

https://tbpl.mozilla.org/?tree=Try&rev=77b2a6024293

Comment 10

[Paul Rouget [:paul]]

Comment on attachment 782664 [details] [diff] [review]
Add getIconAsDataURL in webapps actor

Thanks Alex!

r=me if you reset the pref once the test is finished.

Comment 11

[Alexandre Poirot [:ochameau]]

Attachment: Reset the pref to the original value during tests

Comment 12

[Alexandre Poirot [:ochameau]]

Comment on attachment 783344 [details] [diff] [review]
Reset the pref to the original value during tests

Carrying r+ after having addressed review comment.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/213244df4e6e

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/213244df4e6e