898005 - servo's bors is broken

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

2013-07-25 09:06:01 PDT - INFO - ---------- starting run ----------
2013-07-25 09:06:01 PDT - INFO - loading bors.cfg
2013-07-25 09:06:01 PDT - INFO - loading pull reqs (page 1)
2013-07-25 09:06:02 PDT - INFO - loading pull reqs (page 2)
2013-07-25 09:06:03 PDT - INFO - loading pull and issue comments on pull #620
2013-07-25 09:06:04 PDT - INFO - loading head comments on sonwow/servo/bindings = 65d2ea2f
2013-07-25 09:06:06 PDT - INFO - loading statuses of sonwow/servo/bindings = 65d2ea2f
2013-07-25 09:06:06 PDT - INFO - loading mergeability of 620
2013-07-25 09:06:06 PDT - INFO - loading pull and issue comments on pull #619
2013-07-25 09:06:08 PDT - INFO - loading head comments on kmcallister/servo/script-redisplay = dc9f7560
2013-07-25 09:06:09 PDT - INFO - loading statuses of kmcallister/servo/script-redisplay = dc9f7560
2013-07-25 09:06:09 PDT - INFO - loading mergeability of 619
2013-07-25 09:06:10 PDT - INFO - loading pull and issue comments on pull #618
2013-07-25 09:06:11 PDT - INFO - loading head comments on kmcallister/servo/test-html = 350c0a61
2013-07-25 09:06:13 PDT - INFO - loading statuses of kmcallister/servo/test-html = 350c0a61
2013-07-25 09:06:13 PDT - INFO - loading mergeability of 618
2013-07-25 09:06:13 PDT - INFO - loading pull and issue comments on pull #553
Traceback (most recent call last):
  File "/builds/bors/servo/bin/bors", line 9, in <module>
    load_entry_point('bors==1.1', 'console_scripts', 'bors')()
  File "/builds/bors/servo/lib/python2.7/site-packages/bors.py", line 548, in main
    all_pulls ]
  File "/builds/bors/servo/lib/python2.7/site-packages/bors.py", line 219, in __init__
    self.get_pull_comments()
  File "/builds/bors/servo/lib/python2.7/site-packages/bors.py", line 242, in get_pull_comments
    + self.dst().issues(self.num).comments().get())
  File "/builds/bors/servo/lib/python2.7/site-packages/github.py", line 184, in __call__
    return self._gh._http(self._method, self._path, **kw)
  File "/builds/bors/servo/lib/python2.7/site-packages/github.py", line 158, in _http
    resp = JsonObject(code=e.code, json=json)
UnboundLocalError: local variable 'json' referenced before assignment


There's an obvious bug in github.py, which is an upstream library that bors has a copy of. I don't know why we're hitting this all of a sudden though.

Comment 1

[[e-mail] (:bhearsum)]

I filed an issue with Bors on this: https://github.com/graydon/bors/issues/12

But it looks like the main issue here is github being flaky - it's intermittently returning funny response.