Closed
Bug 898105
Opened 11 years ago
Closed 11 years ago
Remove nsIDOMTouch
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: dzbarsky, Assigned: dzbarsky)
Details
Attachments
(1 file)
13.56 KB,
patch
|
reuben
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
Comment on attachment 781173 [details] [diff] [review] Patch Review of attachment 781173 [details] [diff] [review]: ----------------------------------------------------------------- r=me with these fixed. ::: content/events/src/Touch.h @@ +113,5 @@ > + nsCOMPtr<mozilla::dom::EventTarget> mTarget; > + mozilla::dom::EventTarget *GetTarget() { return mTarget; } > + nsIntPoint mRefPoint; > + bool mChanged; > + uint32_t mMessage; Please remove this stuff from nsIDOMTouchEvent.idl. ::: widget/InputData.h @@ +69,5 @@ > > /** > * Data container for a single touch input. Similar to dom::Touch, but used in > * off-main-thread situations. This is more for just storing touch data, whereas > + * dom::Touch is more useful for dispatching 8/10 for updating the comment, 1/10 for being lazy and not fixing line widths. Please fix. ::: widget/xpwidgets/InputData.cpp @@ +53,5 @@ > domTouch->mRefPoint.y)), > + ScreenSize(domTouch->RadiusX(), > + domTouch->RadiusY()), > + domTouch->RotationAngle(), > + domTouch->Force()); I like this a lot.
Attachment #781173 -
Flags: review?(reuben.bmo) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/40683014a638
Assignee | ||
Comment 4•11 years ago
|
||
backed out https://hg.mozilla.org/integration/mozilla-inbound/rev/74a36d1b2816
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/43dea4b020af
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/43dea4b020af
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•