Status

()

defect
RESOLVED FIXED
6 years ago
4 months ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

No description provided.
Posted patch PatchSplinter Review
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Attachment #781173 - Flags: review?(reuben.bmo)
Comment on attachment 781173 [details] [diff] [review]
Patch

Review of attachment 781173 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with these fixed.

::: content/events/src/Touch.h
@@ +113,5 @@
> +  nsCOMPtr<mozilla::dom::EventTarget> mTarget;
> +  mozilla::dom::EventTarget *GetTarget() { return mTarget; }
> +  nsIntPoint mRefPoint;
> +  bool mChanged;
> +  uint32_t mMessage;

Please remove this stuff from nsIDOMTouchEvent.idl.

::: widget/InputData.h
@@ +69,5 @@
>  
>  /**
>   * Data container for a single touch input. Similar to dom::Touch, but used in
>   * off-main-thread situations. This is more for just storing touch data, whereas
> + * dom::Touch is more useful for dispatching

8/10 for updating the comment, 1/10 for being lazy and not fixing line widths. Please fix.

::: widget/xpwidgets/InputData.cpp
@@ +53,5 @@
>                                           domTouch->mRefPoint.y)),
> +                         ScreenSize(domTouch->RadiusX(),
> +                                    domTouch->RadiusY()),
> +                         domTouch->RotationAngle(),
> +                         domTouch->Force());

I like this a lot.
Attachment #781173 - Flags: review?(reuben.bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/43dea4b020af
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.