898129 - Assertion "Bad uniform location." in LayerManagerOGLProgram.cpp

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I get an assertion here:
  http://mxr.mozilla.org/mozilla-central/source/gfx/layers/opengl/LayerManagerOGLProgram.cpp#310

for the "uTextureTransform" location. According to Matt,

<mattwoodrow> so uTextureTransform is used in the vertex shader to compute vTexCoord
<mattwoodrow> and the normal fragment shaders read from vTexCoord
<mattwoodrow> *but* the ColorLayer frag shader ignores vTexCoord (since there's no texture to read from, so no need for texture coords)
<mattwoodrow> so your GL implementation is optimising the whole thing out

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Not sure if this is what Matt had in mind.

Bill, does this patch make a difference?

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: bug898129

I think we need to get rid of the callers to SetTextureTransform when we have a ColorLayer program too.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I'm assuming you don't want me to try this out anymore.

Comment 4

[Nick Cameron [:nrc]]

Comment on attachment 783303 [details] [diff] [review]
bug898129

Review of attachment 783303 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/CompositorOGL.cpp
@@ +1158,5 @@
>  
>        program->Activate();
>        program->SetTextureUnit(0);
>        program->SetLayerOpacity(aOpacity);
> +      program->SetTextureTransform(gfx3DMatrix());

I think you need similar additions for the other two effect types.

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Oops, I didn't realize there was a new patch. It fixes the problem for me.

Comment 6

[Mike Hommey [:glandium]]

I don't which of bug 893824, bug 900133 or bug 898129 caused it, but inbound has been closed for long enough.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e1009e4b1e1

Comment 7

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8808316e03bb

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8808316e03bb