898130 - set AMO-compatible Firefox targetApplication/maxVersion for desktop-helper/activities extensions

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

AMO's extension validator requires all install.rdf files inside extensions to specify an application and maxVersion listed on <https://addons.mozilla.org/en-US/firefox/pages/appversions/>.

That includes extensions inside other extensions, like the desktop-helper and activities extensions inside the Gaia profile shipped by the Simulator extension, even though those "inner" extensions will never be installed directly by an AMO user.

So this change makes desktop-helper specify compatibility with Firefox (it previously specified compatibility with "Toolkit", which includes Firefox, but AMO requires "Toolkit" extensions to also specify a specific product).

And it makes both desktop-helper and activities claim a Firefox maxVersion of 25.*, which is apparently preferable to (and more reliable than) 25.0.*, even though the aforementioned web page claims the latter variant is also supported.

The IRC conversation in #amo-editors:

---
10:54:58 - myk: editors! the validator doesn't appear to recognize [e-mail] as a "supported Mozilla product"; but doesn't that designation include multiple supported products?
10:56:33 - John-Galt: myk: It does, but for AMO uploads you still need to include a specific product.
10:57:41 - myk: John-Galt: ah, ok; on another note, i'm also getting 'Version "24.0.*" isn't compatible with "firefox"', which is not what https://addons.mozilla.org/en-US/firefox/pages/appversions/ says
10:59:57 - John-Galt: myk: You should use 24.*. The only reason we have 24.0.* is that the language pack build process generates those.
---

I built the Simulator with the change and validated it with <https://github.com/mozilla/amo-validator> locally to verify that the change resolves the issue.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 781206 [details]
patch v1: fixes problem

Thanks.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Merged:

https://github.com/mozilla-b2g/gaia/pull/11170

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Erm, here's the actual commit I merged:

https://github.com/mozilla-b2g/gaia/commit/7315f49c817f56b57ab453bf184f0587cdd1795e

Also cherry-picked and uplifted to v1-train as NPOTB:

https://github.com/mozilla-b2g/gaia/commit/714fb6149d9b7b8ed065ab90a63c0a032b4a6632