Validate Server Response using Hawk

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cade, Assigned: cade)

Tracking

Details

(Whiteboard: s=20130729 p=1)

Attachments

(5 attachments)

(Assignee)

Description

5 years ago
We can, so why not. It will further protect us from MITM attacks.
(Assignee)

Updated

5 years ago
Depends on: 869951
(Assignee)

Updated

5 years ago
Whiteboard: s=20130729 p=1
(Assignee)

Comment 1

5 years ago
Created attachment 782602 [details] [review]
https://github.com/mozilla/makeapi-client/pull/9

Not too hard at all!

when the node client is making authenticated calls to the MakeAPI, it'll also verify the integrity of the servers responses. (similar to the way the server verifies the client's message integrity)
Attachment #782602 - Flags: review?(david.humphrey)
Attachment #782602 - Flags: review?(david.humphrey) → review-
(Assignee)

Comment 2

5 years ago
Comment on attachment 782602 [details] [review]
https://github.com/mozilla/makeapi-client/pull/9

updated!
Attachment #782602 - Flags: review- → review?(david.humphrey)
Attachment #782602 - Flags: review?(david.humphrey) → review-
(Assignee)

Comment 3

5 years ago
Comment on attachment 782602 [details] [review]
https://github.com/mozilla/makeapi-client/pull/9

Fixed up that incorrect error callback. Thanks for the thorough review!
Attachment #782602 - Flags: review- → review?(david.humphrey)
Attachment #782602 - Flags: review?(david.humphrey) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 783142 [details] [review]
https://github.com/mozilla/webmaker.org/pull/301

webmaker.org update for makeapi-client
Attachment #783142 - Flags: review?(david.humphrey)
(Assignee)

Comment 5

5 years ago
Created attachment 783143 [details] [review]
https://github.com/mozilla/MakeAPI/pull/127

Makeapi update to makeapi-client v0.5.6
Attachment #783143 - Flags: review?(david.humphrey)
(Assignee)

Comment 6

5 years ago
Created attachment 783144 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/142

popcorn maker update to makeapi-client v0.5.6
Attachment #783144 - Flags: review?(david.humphrey)
(Assignee)

Comment 7

5 years ago
Created attachment 783145 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/188

Thimble update to makeapi-client v0.5.6
Attachment #783145 - Flags: review?(david.humphrey)
Attachment #783142 - Flags: review?(david.humphrey) → review+
Attachment #783143 - Flags: review?(david.humphrey) → review+
Attachment #783144 - Flags: review?(david.humphrey) → review+
Attachment #783145 - Flags: review?(david.humphrey) → review+
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain text/plain text/plain text/plain text/plain → text/x-github-pull-request text/x-github-pull-request text/x-github-pull-request text/x-github-pull-request text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.