Closed
Bug 898205
Opened 12 years ago
Closed 8 years ago
Optimize SocialMarks.update/updateMarkState
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: MattN, Unassigned)
Details
(Keywords: perf)
Attachments
(1 file)
2.27 KB,
patch
|
Details | Diff | Splinter Review |
onLocationChange calls SocialMark.updateMarkState() which could be a bit more performant by memoizing the button element and separating update and updateMarkState so that updateMarkState only does stuff needed on location changes while update does everything else that is independent of the currentURI.
Try push: https://tbpl.mozilla.org/?tree=Try&rev=92e2fa928f9b
Comment 1•11 years ago
|
||
AFAIK all this code is gone now - INVALID?
Reporter | ||
Comment 2•11 years ago
|
||
SocialMark was renamed to SocialMarks but there are some of the same issues still[1]. I think it's worth double-checking that the work done as a result of a location change is minimized.
[1] https://mxr.mozilla.org/mozilla-central/search?string=return+document.getElementById("social-
Summary: Optimize SocialMark.update/updateMarkState → Optimize SocialMarks.update/updateMarkState
Reporter | ||
Updated•10 years ago
|
Assignee: MattN+bmo → nobody
Status: ASSIGNED → NEW
Comment 3•8 years ago
|
||
deprecation in fx51
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•