Closed Bug 898205 Opened 12 years ago Closed 8 years ago

Optimize SocialMarks.update/updateMarkState

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: MattN, Unassigned)

Details

(Keywords: perf)

Attachments

(1 file)

Attached patch WIP 1 - UntestedSplinter Review
onLocationChange calls SocialMark.updateMarkState() which could be a bit more performant by memoizing the button element and separating update and updateMarkState so that updateMarkState only does stuff needed on location changes while update does everything else that is independent of the currentURI. Try push: https://tbpl.mozilla.org/?tree=Try&rev=92e2fa928f9b
AFAIK all this code is gone now - INVALID?
SocialMark was renamed to SocialMarks but there are some of the same issues still[1]. I think it's worth double-checking that the work done as a result of a location change is minimized. [1] https://mxr.mozilla.org/mozilla-central/search?string=return+document.getElementById("social-
Summary: Optimize SocialMark.update/updateMarkState → Optimize SocialMarks.update/updateMarkState
Assignee: MattN+bmo → nobody
Status: ASSIGNED → NEW
deprecation in fx51
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: