After discussing this with Gavin, Jon, and Dale we think using bower to manage our front end dependencies would be a great thing to do going forward. It allows us to: - easily keep things like font-awesome up to date - write and maintain frontend libraries as separate modules for re-use across our other projects. In this patch, for example, I include the makeapi-client as a bower dependency instead of symlinking it or rendering config options into nunjucks templates and reading with js. - reduces the amount of code in the repo Using bower should feel -very- familiar to the team since it uses similar syntax to npm and follows similar conventions. Installing it is also super simple: npm install -g bower
Also, since bower is node, we can include a postinstall script in our package.json that should work with our deployment tools.
Comment on attachment 781406 [details] [review] https://github.com/mozilla/webmaker.org/pull/293 This is awesome! Some nits noted in the PR to fix up and unfortunately events don't work at all due to a jquery path error: -- [11:52:35.766] Error: Script error for: jquery http://requirejs.org/docs/errors.html#scripterror @ http://localhost:7777/ext/requirejs/require.js:163
Attachment #781406 - Flags: review?(jon) → review-
Comment on attachment 781406 [details] [review] https://github.com/mozilla/webmaker.org/pull/293 Updated, moved bower stuff to bower_components
Attachment #781406 - Flags: review- → review?(jon)
Comment on attachment 781406 [details] [review] https://github.com/mozilla/webmaker.org/pull/293 r+ with nits, remove that rogue console.log
Attachment #781406 - Flags: review?(jon) → review+
Commit pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/4aab17f127d4ff6fa094e079f5f4e3d2533ec2ad Fix bug 898243 - Added bower for front end deps
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
Attachment #781406 - Flags: feedback?(gavin) → feedback?
You need to log in before you can comment on or make changes to this bug.