Closed Bug 898257 Opened 11 years ago Closed 11 years ago

HD: costcontrol canvas is blur

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Cost Control
Platform:
Other
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:hd+, b2g18 fixed, b2g-v1.1hd fixed)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g hd+
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(4 files, 1 obsolete file)

device-2013-07-25-162923.png
62.63 KB, image/png
Details
device-2013-07-30-183107.png
60.94 KB, image/png
Details
pull_request.html
181 bytes, text/html
salva
: review+
Details
device-2013-08-01-174419.png
61.70 KB, image/png
Details 
in HD device, canvas not scaled, y-axis font is blur

expect result:

sharp canvas and clear fonts
blocking-b2g: --- → hd?
Can anyone in Taipei work on this?
blocking-b2g: hd? → hd+
Flags: needinfo?(ehung)
I'd do the followup work
Assignee: nobody → gasolin
Flags: needinfo?(ehung)
Blocks: 898262
WIP: grid section ok, but fonts are still small

    
    

    
  

      
      
      
      

        Attached file
          
        pull_request.html
        — 
      

    


  
fixed canvas blur issue and make limit line looks similar to origin res.

But number font is still small (even after set font size * pixelRatio) ... need some help on that

        Attachment #784279 -
        Flags: review?(salva)

    
    

    
  

      
      
      
      

        Attached image
          
        device-2013-08-01-163904.png (obsolete)
        — 
      

    


  
current PR looking

    
    

    
  


  
root cause of canvas font Size issue is `context.fontSize` does not exist. Replace to `context.font` works. squashed PR.

        Attachment #784280 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 784279 [details]
pull_request.html

All seems ok to me but please, read the comment on GitHub and wrap the conversion into a function. Thank you very much.

        Attachment #784279 -
        Flags: review?(salva) → review+

    
    

    
  
merged to gaia-master
https://github.com/mozilla-b2g/gaia/commit/da62699b5aeef0654bcfa2189946db0f9505fd13

(use `toDevicePixels` function to perform this conversion instead of inlining it)
thanks!
Status: NEW → RESOLVED
Closed: 11 years ago

          status-b2g18:
          --- → fixed

          status-b2g-v1.1hd:
          --- → affected
Resolution: --- → FIXED

    
    

    
  
Hey guys!

You've landed bug 898262 but that bug introduces changes depending on this one which is not landed on HD while it was flagged as HD+.

Can you land this in order to fix the HD branch, please?
Flags: needinfo?(gasolin)

    
    

    
  
[2013/10/21 Helix Testing]
Gaia:     c829a2042594b6c3a4899ee27979799a0f301534
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019
BuildID   20131015042201
Version   18.0
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: