898293 - [Buri][WIFI]It cannot save network when you input more characters

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P5)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.164
 Firefox os  v1.1
 Mozilla build ID:20130715070218
 
 Created an attachment (id=469942)
 PIC
 
 DEFECT DESCRIPTION:
 It cannot save network when you input more characters
 
 REPRODUCING PROCEDURES:
 1.settings->wifi->manage network->join hidden network
 2.input more characters in SSID name,security choose open
 3.tap "ok",but cannot find it under known network->KO
 
 EXPECTED BEHAVIOUR:
 it should saved normal
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:MID
 
 REPRODUCING RATE:5/5
 
 For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: PIC

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: logcat

Comment 5

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

SSID can't be longer than 32 bytes, the input SSID is too long and cause an error in wpa_supplicant:

07-25 11:14:58.470 E/wpa_supplicant( 1347): Line 0: too long ssid (len=185 max_len=32)

Now we don't have an event to inform that, but this can be limited directly by Gaia.
Note that non-ASCII chars will be encoded into UTF8, and make the actual length of SSID longer than ssid.length.
I don't know if Gaia can calculate the encoded UTF-8 length of a string.

On the other hand, I think this is a case that nearly impossible to happen in normal use.
So it should be low priority.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

We should do the check from Gaia as we check the validity of the password.

Comment 7

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Change component per comment 6.

Comment 8

[Ray REN]

Maybe you could add maxlength to limit user's input as password's input box do.

Comment 9

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

I think maxlength check might fail when containing non-ASCII chars in SSID.
As I mentioned in comment 5, the length has to be calculated char-by-char.

For example you typed '£' in SSID, its length is 1(char). But for SSID usage, its length is 2(bytes) because it has to be encoded by UTF-8, and result is 0xC2 0xA3.

Comment 10

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: Pull Request

Limit length of SSID by length of UTF-8 encoded data.

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 782986 [details]
Pull Request

Thank you for taking care of this! r=me. Please address the comments in github before merging.

Comment 12

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

(In reply to Arthur Chen [:arthurcc] from comment #11)
> Comment on attachment 782986 [details]
> Pull Request
> 
> Thank you for taking care of this! r=me. Please address the comments in
> github before merging.

Done! Thanks~

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

There is still one line (628) over 80 character. Could you help fix it? Thanks!

Comment 14

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Fixed, but I am not sure if I am using the right coding style.

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Chuck, thanks for the effort!

master: https://github.com/mozilla-b2g/gaia/commit/f4a8ea312a6e7417d105b22b35507df0e35b7e2a

Comment 16

[Ray REN]

Hi Arthur, could you add this patch in v1.1?

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

The patch will get uplifted after the bug becomes a leo+.

Comment 18

[Andrew Overholt [:overholt]]

This is unfortunate behaviour.  We discussed it in triage and decided that it wasn't worth blocking v1.1 for the following reasons:

- only reproducible with hidden SSIDs
- only reproducible if the user types in many characters for the SSID
- not a regression from v1.0.1
- unclear that user can't just try other entries for the SSID

Please feel free to re-nom if you disagree.

Comment 19

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

I would like to add another reason:
This bug is rarely reproduced in real life usage - the SSID causes the problem never exists because it violates the 802.11 standard.