[Gallery] Statusbar show when switching from camera app to gallery

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gduan, Assigned: gduan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 781551 [details]
gallery.png

## Environment
Gaia: ccf877b99ace72e621eb5172f042c6c20aa1297a

STR:
1. Open gallery app
2. click one picture
3. click camera icon on the bottom bar, then switch to camera app
4. click left-bottom icon, then switch to gallery app
5. click edit button (center icon on the bottom)

Expect: statusbar should not show
Actual: statusnar show and overlap header

see attachment.
blocking-b2g: --- → leo?
Assignee: nobody → gduan
Triage - Small user impact, no functional impact, polish bug. Leo-
blocking-b2g: leo? → ---
Hi Alive,
I found this bug is from bug 896393.
When animation ends after opening inline window, window_manager will trigger |setCloseFrame(null)|, and then |windowClosed| remove fullscreen-app class from screen. 

I'm thinking to remove |screenElement.classList.remove('fullscreen-app');| from |windowClosed|, since it already be triggered by |setDisplayedApp| before switching/opening/closing app. 

What do you think?
Flags: needinfo?(alive)
Device is not by my side.
IMO clear fullscreen state after window is closed is correct.
So what shall be done is add fullscreen back when the opening app is fullscreen.

Be careful to call windowClosed before openWindow or add the fullscreen state again after windowOpened.
Flags: needinfo?(alive)
Created attachment 784317 [details]
PR to master

This patch add fullscreen-app class to displayed app when invoked/invoking animation is done
Attachment #784317 - Flags: review?(alive)
Attachment #784317 - Attachment description: attach.html → PR to master
Comment on attachment 784317 [details]
PR to master

Ignore my previous comment, your original proposal is fine. Use that. Thanks.
Attachment #784317 - Flags: review?(alive) → review+
Thanks Alive!

Merge into master:
https://github.com/mozilla-b2g/gaia/commit/a8b0a40337b91bfa82795efc36d6defffa2eda23
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.