898297 - [Contacts] Merging process stucks and never ends

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[isabelrios]

Attachment: merging.txt

Unagi device master brach:
Gecko-11373a6
Gaia-ccf877b

This has been reproduced randomly trying to merge different contacts with different options. 
It always happens though when trying to merge two contacts with:
Same Name
Same Last Name
Same Phone number (but one with prefix and the other without)

Adb logcat attached.
I will try to get more logs under other circunstances in case the root cause of the error is not the same.

Comment 1

[Salvador de la Puente González [:salva]]

Find here a reproducible STR:

1- Open contacts and add a new one with name, last name. Save the contact.
2- Add another contact with the same name and last name and a mobile number. Save the contact.
3- When `Duplicates found` window appears, tap on `Merge`

Expected:
The merging process starts and finalizes merging the selected contact and the new one being added into one.

Actual:
The merging process starts but never ends.

Comment 2

[Salvador de la Puente González [:salva]]

Attachment: Fixing the fake matching result, a convenient renaming and some related documentation added.

May Travis fail on Communications but it is the dialer part and master is currently failing on the same tests.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Small comment on github.

Thanks!

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 793432 [details]
Fixing the fake matching result, a convenient renaming and some related documentation added.

Applying KISS ,)

Please, review again and thank you very much for your feedback.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 793432 [details]
Fixing the fake matching result, a convenient renaming and some related documentation added.

Thanks Salva!

Comment 6

[Salvador de la Puente González [:salva]]

Master: 7e83343a1ea9050216dfa150d0897a7d858225c1

Comment 7

[isabelrios]

Verified, master 09/23 build:
Gecko-f156bef
Gaia-3786676