898345 - Contacts matcher in both passive an active mode must support matching by the name field

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

This is needed specially for SIM imported Contacts. The proposed solution should address the following test cases:

in active mode: 

var existingSimContact = {
          id: '1B',
          category: ['sim'],
          name: ['Juan Ramón del SIM'],
          givenName: ['Juan Ramón del SIM'],
          tel: [{
            type: ['home'],
            value: '676767671'
          }],
          email: [{
            type: ['personal'],
            value: '[e-mail]'
          }]
        };

        var incomingContact = {
          id: '678',
          givenName: ['Juan Ramon'],
          familyName: ['del SIM'],
          name: ['Juan Ramón del SIM']
        };

var simObj = {
        id: '678',
        category: ['sim'],
        name: ['Juan Ramón del SIM'],
        givenName: ['Juan Ramón del SIM']
      };

      var existingContact = {
        id: '1B',
        givenName: ['Juan Ramon'],
        familyName: ['del SIM'],
        name: ['Juan Ramón del SIM'],
        tel: [{
          type: ['home'],
          value: '676767671'
        }],
        email: [{
          type: ['personal'],
          value: '[e-mail]'
        }]
      };

in passive mode:

var simObj = {
        id: '678',
        category: ['sim'],
        name: ['Juan Ramón del SIM'],
        givenName: ['Juan Ramón del SIM'],
        tel: [{
          type: ['home'],
          value: '676767671'
        }]
      };

      var existingContact = {
        id: '1B',
        givenName: ['Juan Ramon'],
        familyName: ['del SIM'],
        name: ['Juan Ramón del SIM'],
        tel: [{
          type: ['home'],
          value: '676767671'
        }],
        email: [{
          type: ['personal'],
          value: '[e-mail]'
        }]
      };

var existingSimContact = {
          id: '1B',
          category: ['sim'],
          name: ['Juan Ramón del SIM'],
          givenName: ['Juan Ramón del SIM'],
          tel: [{
            type: ['home'],
            value: '676767671'
          }],
          email: [{
            type: ['personal'],
            value: '[e-mail]'
          }]
        };

        var incomingContact = {
          id: '678',
          givenName: ['Juan Ramon'],
          familyName: ['del SIM'],
          name: ['Juan Ramón del SIM'],
          tel: [{
            type: ['home'],
            value: '676767671'
          }]
        };

Comment 1

[Jose Manuel Cantera]

Attachment: Pointer to GH PR 11185

Proposed patch for Gaia but for working 100% it needs bug 893337 fixed

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 781625 [details]
Pointer to GH PR 11185

Thanks for your work

Comment 3

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/65a3292841c33f59ceeace8d37817c5093a09b2b

Comment 4

[Julien Wajsberg [:julienw]]

Jose Manual, now that bug 898337 is fixed, do you need to do more work to use it in the Contacts app? If yes, let's file a new bug for this work!