[User Story] Timer Notification

RESOLVED FIXED

Status

Firefox OS
Gaia::Clock
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: pdol, Assigned: oconnore)

Tracking

({feature})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ucid:Productivity37])

Attachments

(1 attachment, 1 obsolete attachment)

46 bytes, text/x-github-pull-request
jugglinmike
: review+
Details | Review | Splinter Review
(Reporter)

Description

5 years ago
User Story:

As a user I want to be notified when the specified count down time has elapsed so that I don't need to keep track by keeping the count down timer open.


Acceptance Criteria:

1. If my device volume is not set to silent, after the count down reaches 0, I am visually and audibly notified.
2. If my device volume is set to silent, after the count down reaches 0, I am visually notified.
(Reporter)

Comment 1

5 years ago
Accidental nom.  Not a blocking feature.
blocking-b2g: koi? → ---
(Assignee)

Updated

5 years ago
Blocks: 898456
(Assignee)

Updated

5 years ago
Depends on: 913002
(Assignee)

Updated

5 years ago
Duplicate of this bug: 937597
(Assignee)

Updated

5 years ago
Depends on: 898366
(Assignee)

Updated

5 years ago
Assignee: nobody → eric
Blocks: 902999
(Assignee)

Comment 3

4 years ago
Created attachment 8347420 [details] [review]
github pr

Hey Mike,

This patch is ready for review.
Attachment #8347420 - Flags: review?(mike)
Comment on attachment 8347420 [details] [review]
github pr

Alright, Eric! I've finished reviewing the patch--comments on the GitHub pull request.
Attachment #8347420 - Flags: review?(mike)
(Assignee)

Comment 5

4 years ago
Comment on attachment 8347420 [details] [review]
github pr

Ok Mike, I made changes per your review. Let me know how it looks.
Attachment #8347420 - Flags: review?(mike)
Comment on attachment 8347420 [details] [review]
github pr

Hi Eric,

I think we're almost there. See the pull request on GitHub for in-line review comments.
Attachment #8347420 - Flags: review?(mike)
(Assignee)

Comment 7

4 years ago
Comment on attachment 8347420 [details] [review]
github pr

code++
Attachment #8347420 - Flags: review?(mike)
Comment on attachment 8347420 [details] [review]
github pr

Give me an e-holler when you get the Snooze bug worked out!
Attachment #8347420 - Flags: review?(mike)
(Assignee)

Comment 9

4 years ago
Comment on attachment 8347420 [details] [review]
github pr

yo!
Attachment #8347420 - Flags: review?(mike)
Comment on attachment 8347420 [details] [review]
github pr

Looking good!
Attachment #8347420 - Flags: review?(mike) → review+
master: https://github.com/mozilla-b2g/gaia/commit/8862901daa7b9befce33d1d679091f26437386d1

Nice work, Eric
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
reverted: https://github.com/mozilla-b2g/gaia/commit/b835ffc38821c7693877a158ca2f961890b7fcd8

Eric: that patch caused the Timer panel to re-draw much too often. The `tickTimeout` calculated by `Timer.Panel#tick` should reference `this.startTime` instead of `this.start`. Could you please update your patch to avoid this inefficiency?

Sorry I didn't catch this sooner.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 958731
(Assignee)

Comment 13

4 years ago
Created attachment 8360701 [details] [review]
github pr

Hey Mike, this should fix the performance regression.
Attachment #8347420 - Attachment is obsolete: true
Attachment #8360701 - Flags: review?(mike)
Comment on attachment 8360701 [details] [review]
github pr

Thanks, Eric
Attachment #8360701 - Flags: review?(mike) → review+
master: https://github.com/mozilla-b2g/gaia/commit/ef8bb31b462f364b57432a0724c78034d3f4f303
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED

Updated

4 years ago
blocking-b2g: --- → 1.3?
Clearing nomination; this is a 1.4 feature but it's too late to add this to 1.3.
blocking-b2g: 1.3? → ---

Comment 17

4 years ago
Dears,

If don't add this to v1.3, the usability of timer will be seriously discounted, what do you think? 
Please land it to v1.3, there is still time to complete this work.

Thanks.
blocking-b2g: --- → 1.3?
Flags: needinfo?(vchen)
We agree that this is an important enhancement to the Timer but we are too far past the feature complete date to attempt uplift of this feature. There are a number of other dependent bugs here as well -- it's too risky to pull this in to 1.3.
blocking-b2g: 1.3? → ---

Updated

4 years ago
Depends on: 978683

Updated

4 years ago
Depends on: 979530

Updated

4 years ago
Depends on: 1009977
You need to log in before you can comment on or make changes to this bug.