Unable to update makes via makeapi.webmaker.org

RESOLVED FIXED

Status

Webmaker
MakeAPI
--
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: inactivate account for kate, Assigned: cade)

Tracking

Details

Attachments

(5 attachments)

(Reporter)

Description

5 years ago
Yesterday evening Kat was reporting a bug on makeapi.webmaker.org the she was unable to update makes via the /admin interface.

STR:
- Login to makeapi.webmaker.org, got to /admin
- Try editing a make (add a tag, webmaker:test-1 for example)
- Refresh page
Expected:
- Make is updated with new take
Actual
- On page refesh, make reverts to original state.

No console errors - this was happening on Firefox and Chrome.

I could not reproduce locally/remotely with my own account.

Is this an LDAP probem? Something specific with Kat's account privileges? Any ideas?
(Assignee)

Comment 1

5 years ago
The problem here was that we neglected to update the update function for wrapped makes in makeapi-client. Patch incoming.
(Assignee)

Comment 2

5 years ago
Created attachment 781683 [details] [review]
https://github.com/mozilla/makeapi-client/pull/8

will have to land this, tag it, then create package.json updates to Popcorn Maker, Thimble and Webmaker. >.<
Attachment #781683 - Flags: review?(kate)
(Assignee)

Comment 3

5 years ago
Critical because updating using the makeapi admin tool is broken on prod. Might affect thimble and popcorn makes as well.
Severity: normal → critical
(Reporter)

Comment 4

5 years ago
Comment on attachment 781683 [details] [review]
https://github.com/mozilla/makeapi-client/pull/8

Fixes the issue locally for me
Attachment #781683 - Flags: review?(kate) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 781695 [details] [review]
https://github.com/mozilla/MakeAPI/pull/120

MakeAPI update to makeapi-client v0.5.5
Attachment #781695 - Flags: review?(kate)
(Assignee)

Comment 6

5 years ago
Created attachment 781696 [details] [review]
https://github.com/mozilla/webmaker.org/pull/295

webmaker.org update to makeapi-client v0.5.5
Attachment #781696 - Flags: review?(kate)
(Assignee)

Comment 7

5 years ago
Created attachment 781697 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/185

Update thimble to makeapi-client v0.5.5
Attachment #781697 - Flags: review?(kate)
(Assignee)

Comment 8

5 years ago
Created attachment 781698 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/139

update Popcorn Make to makeapi-client v0.5.5
Attachment #781698 - Flags: review?(kate)
(Reporter)

Updated

5 years ago
Attachment #781698 - Flags: review?(kate) → review+
(Reporter)

Updated

5 years ago
Attachment #781696 - Flags: review?(kate) → review+
(Reporter)

Updated

5 years ago
Attachment #781697 - Flags: review?(kate) → review+
(Reporter)

Updated

5 years ago
Attachment #781695 - Flags: review?(kate) → review+
(Assignee)

Comment 13

5 years ago
Fixes landed on Prod!
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain text/plain text/plain text/plain text/plain → text/x-github-pull-request text/x-github-pull-request text/x-github-pull-request text/x-github-pull-request text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.