898412 - [Bluetooth] Redundant notification of received file

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[ayman maat :maat]

Attachment: Transfer Complete Notifications.png

Redundant notification of received file

**PATH 1**
1.1) open Settings app
1.2) Select Bluetooth
1.3) Select Bluetooth (to turn it on)
1.4) Select Visible to all (to turn it on)
1.5) on another device select a contact and send its vcard to the Unagi device 
1.6) On the Unagi device open the notifications tray
1.7) Select the notification of the new transfer request, the user is presented with the overlay attached 
1.8) Select transfer

**EXPECTED**
Upon completion of transfer the user will receive a single notification that the transfer is complete.

**ACTUAL**
Upon completion of transfer the user receives two simultaneous notifications that the transfer is complete. One at the top of the screen and one at the bottom. One of these two simultaneous notifications is redundant and therefore is causing noise on the screen.

Comment 1

[Eric Chou [:ericchou] [:echou]]

This is more related to UX/UI polish. Change component from Bluetooth to Gaia::BluetoothFileTransfer.

Comment 2

[[e-mail], [e-mail]]

NeedInfo UX team for polish. In side of implementation, we wakeup the devices via notification. I think that the banner could be minor.

Comment 3

[Stephany Wilkes]

Flagging Eric since this appears more VxD, and Ayman as an FYI/CC.

Comment 4

[Eric Pang [:epang] UX]

(In reply to Stephany Wilkes from comment #3)
> Flagging Eric since this appears more VxD, and Ayman as an FYI/CC.

If Ayman agrees I believe the bottom notification can be removed.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Emailed Ayman to try and get some input here so this can move forward.

Comment 6

[Stephany Wilkes]

Thanks, Lukas! Sorry for the delay. Ayman had, earlier in 1.2, also been waiting for feedback from Taipei UX, so I have added Juwei and Carrie here as well in case one of them can address this.

Comment 7

[ayman maat :maat]

(In reply to [e-mail] [:lsblakk] from comment #5)
> Emailed Ayman to try and get some input here so this can move forward.

Sorry guys overlooked this

we have two bugs with very similar issues. This and bug 915154. Maybe we should tackle these together?


(In reply to Eric Pang [:epang] from comment #4)
> (In reply to Stephany Wilkes from comment #3)
> > Flagging Eric since this appears more VxD, and Ayman as an FYI/CC.
> 
> If Ayman agrees I believe the bottom notification can be removed.

Hey Eric, if the top notification is shown the bottom one can be suppressed.

Comment 8

[Eric Pang [:epang] UX]

(In reply to ayman maat :maat from comment #7)
> (In reply to [e-mail] [:lsblakk] from comment #5)
> > Emailed Ayman to try and get some input here so this can move forward.
> 
> Sorry guys overlooked this
> 
> we have two bugs with very similar issues. This and bug 915154. Maybe we
> should tackle these together?
> 
> 
> (In reply to Eric Pang [:epang] from comment #4)
> > (In reply to Stephany Wilkes from comment #3)
> > > Flagging Eric since this appears more VxD, and Ayman as an FYI/CC.
> > 
> > If Ayman agrees I believe the bottom notification can be removed.
> 
> Hey Eric, if the top notification is shown the bottom one can be suppressed.

Thanks Ayman!

Comment 10

[Carrie Wang [New account: [e-mail]]]

(In reply to Stephany Wilkes from comment #6)
> Thanks, Lukas! Sorry for the delay. Ayman had, earlier in 1.2, also been
> waiting for feedback from Taipei UX, so I have added Juwei and Carrie here
> as well in case one of them can address this.

Hi guys,

Since we have a notification at the top of screen while the transfer has started. I'd suggest that we should remove the one at the bottom when it is completed to make sure the system behavior is consistent. Thanks!

Comment 11

[Juwei Huang[:juwei]]

Agree with Carrie!

Comment 12

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request 12360.html

* Remove redundant banner message from bluetooth file transfer.

Alive,

Could you please help to review the pr? Thanks.

Comment 13

[[e-mail], [e-mail]]

Thanks for Alive's reviewing effort. Since the pr is merged, we can close the issue now.

Gaia/master:  abd9988a27a62d1857a8674d823aa1f29753f16e

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

koi+ for landing into v1.2

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted abd9988a27a62d1857a8674d823aa1f29753f16e to:
v1.2: 51ada8a9986005a158bc403870cfe3e9f7d67082

Comment 16

[isabelrios]

Verified on 09/24 v1.2 build:
Gecko-85ead36
Gaia-a22ba4a

The notification at the bottom does not appear when receiving a file via Bluetooth