Closed Bug 898442 Opened 7 years ago Closed 7 years ago

IonSpewer accidentally skips some functions

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: sunfish, Unassigned)

Details

Attachments

(1 file)

Attached patch a proposed fixSplinter Review
In IonSpewer.cpp, beginFunction doesn't increment the filteredOutCompilations counter in the case where an IonSpewer is not inited_, but endFunction decrements the counter even when it is not inited_. This causes filteredOutCompilations to wrap around and be non-zero for subsequent functions when it should be zero, which spuriously suppresses output for them.
Attachment #781714 - Flags: review?(nicolas.b.pierron)
Attachment #781714 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/770b97caaaba
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.