IonSpewer accidentally skips some functions

RESOLVED FIXED in mozilla25

Status

()

Core
JavaScript Engine
--
enhancement
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: sunfish, Unassigned)

Tracking

Trunk
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Created attachment 781714 [details] [diff] [review]
a proposed fix

In IonSpewer.cpp, beginFunction doesn't increment the filteredOutCompilations counter in the case where an IonSpewer is not inited_, but endFunction decrements the counter even when it is not inited_. This causes filteredOutCompilations to wrap around and be non-zero for subsequent functions when it should be zero, which spuriously suppresses output for them.
Attachment #781714 - Flags: review?(nicolas.b.pierron)
Attachment #781714 - Flags: review?(nicolas.b.pierron) → review+
(Reporter)

Comment 1

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/770b97caaaba
https://hg.mozilla.org/mozilla-central/rev/770b97caaaba
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.