898463 - [webmaker-suite] add noxmox to all suite apps for seemless offline "S3" work

Status: RESOLVED FIXED

(Webmaker Graveyard :: Webmaker-suite, defect)

Description

[William Duyck [:fuzzyfox]]

It would be great to have support for FakeS3 so that those without S3 auth details can run their own offline instances.

Comment 1

[William Duyck [:fuzzyfox]]

Hold tight on working on this if you haven't started. I'm working on a fix right now.

Comment 2

[Pomax]

Awesome to have you jump in: set me as a review? when you're happy with what you have, and I'll look it over! (for github pull requests, create an attachment and then paste the pull request link as text in both the big "file" textarea, as well as in the "description" text field. You can leave everything else as is, and then set review to "?" on me (just type :pomax and wait for bugzilla to suggest you the full bugzilla name/address)

Comment 3

[William Duyck [:fuzzyfox]]

Attachment: https://github.com/Pomax/webmaker-suite/pull/6

Pull request for review

Comment 4

[Pomax]

Comment on attachment 783019 [details] [review]
https://github.com/Pomax/webmaker-suite/pull/6

code looks pretty good, the readme.md just needs some extra text where we talk about requirements to highlight that people will also need ruby (for running gem installs)

Comment 5

[William Duyck [:fuzzyfox]]

Readme updated. Missed that part :/

Comment 6

[Pomax]

humph pointed out the https://npmjs.org/package/noxmox package, which might be worth using instead of fakes3 when apps start up in dev mode.

Comment 7

[Pomax]

taking, as fuzzyfox will likely not have time to work on this for a few weeks.

Comment 8

[Pomax]

noxmox has a bug on win32 where it tries to write a tempfile to a dir in the root (forbidden by UAC), https://github.com/nephics/noxmox/issues/8 filed to raise that issue with the author.

Comment 9

[Pomax]

https://github.com/nephics/noxmox/pull/10 filed to address the issues in noxmox

Comment 10

[Pomax]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/219

Tester to see if we like how this works. If we do, I can add this into popcorn and goggles, too, and then move the mox-server into its own mini repo so that it can serve data for all three tools without needing to run three times.

Comment 11

[Pomax]

using noxmox's "mox" for emulated S3 looks like a better solution than using fakes3, and slots quite easily into tools that already use knox for S3 interfacing. needinfo is mostly about whether this seems a sensible thing (I think so) and how we want to control whether it kicks in or not. Not all localhost work is offline work, so we might want a new env var a la S3_LOCALONLY=true, or perhaps even something completely different. Opinions welcome =)

Comment 12

[Chris DeCairos (:cade)]

Comment on attachment 806312 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/219

1. It looks like we force the use of mox when in development mode, I think it should be disabled if there are s3 credentials provided.
2. I can't test because there's no such file in the feature branch named "./lib/mox-server.js" :P

Comment 13

[Pomax]

Comment on attachment 806312 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/219

made the "is mox necessary?" a new flag called S3_EMULATION=[true/false] so that being in dev mode doesn't automatically mean you're forced to emulate s3. Also fixed the mox-server requirement.

Comment 14

[David Humphrey (:humph)]

I think this is a good idea, see how they do this in webmaker-events: https://github.com/mozilla/webmaker-events/blob/master/lib/s3.js#L49

I think we should use it everywhere we do S3.

Comment 15

[Pomax]

Cade had the idea of making emulation also implicit to not providing S3 credentials. This is an excellent idea, and allows use to have empty-valued variables in env.dist/sample which is much cleaner than using dummy values that'd break a real S3 system. Updating the patch to work this in.

Comment 16

[Pomax]

patch updated; if S3_EMULATION is false or left off, but S3_KEY has no value, then the app will run in emulated S3 mode

Comment 17

[Chris DeCairos (:cade)]

Comment on attachment 806312 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/219

Very nice. R+

Comment 18

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/f71a6b79d53dad7f00a19ab7d343e165df711c47
Merge pull request #219 from Pomax/bug898463

noxmox as S3 emulation

Comment 19

[Pomax]

morphing ticket to tracker ticket for the other projects.

Comment 20

[Pomax]

all tools updated. resolving for great justice.