898473 - download button icon is zoomed in, too large, after download completes

Status: VERIFIED INVALID

(Firefox :: Downloads Panel, defect)

Description

[Edwin Wong [:edwong]]

Attachment: Screen Shot 2013-07-26 at 8.56.20 AM.png

I'm on a mac book pro retina. Repro on FF23 only.

1. download something
2. look at download button on top right controls.

actual: see attachement

expected: should just be blue but not 'zoomed' in

Comment 1

[u279076]

You do not see this on Firefox 24 or 25?

Comment 2

[Edwin Wong [:edwong]]

The icon is offset, missing arrow symbol, and looks incorrect on FF25

Comment 3

[u279076]

(In reply to Edwin Wong [:edwong] from comment #2)
> The icon is offset, missing arrow symbol, and looks incorrect on FF25

So this happens in Firefox 23 onward but not Firefox 22 and earlier?

Comment 4

[Edwin Wong [:edwong]]

Anthony: yes - I see it on 23 and greater, which is now live as stable.

Comment 5

[u279076]

(In reply to Edwin Wong [:edwong] from comment #4)
> Anthony: yes - I see it on 23 and greater, which is now live as stable.

Thanks, can you try to narrow this down using the Firefox 23 Nightly builds?

1. See if it reproduces in the first 23 Nightly:
> ftp://ftp.mozilla.org/pub/firefox/nightly/2013/04/2013-04-02-03-08-43-mozilla-central/
2. If not, see if it reproduces in the last 23 Nightly:
> ftp://ftp.mozilla.org/pub/firefox/nightly/2013/05/2013-05-13-03-10-57-mozilla-central/
3. If so, use mozregression to regress it further:
> http://mozilla.github.io/mozregression/

Assuming the above dates are correct, use the following command:
> mozregression --good=2013-04-02 --bad=2013-05-13

Then copy and paste the output to this bug.

Comment 7

[bugzilla]

Created attachment 775119 [details]
Bug.jpg

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20130712 Firefox/24.0 (Nightly/Aurora)
Build ID: 20130712004003

Steps to reproduce:

I just download the spotify installer. But the problem comes with a other download before too.


Actual results:

After the download is end, the download icon will be blue, maximized and goes back.
But during the animation, the icon stops his animation.


Expected results:

The animation should ends normaly.

Comment 8

[bugzilla]

Attachment: Bug.jpg

Comment 9

[u279076]

Patrick, would you mind testing the builds mentioned in comment 5? Thanks

Comment 10

[bugzilla]

I will try it today evening.

Comment 11

[bugzilla]

Is that enough?:
Patricks-MacBook-Pro:~ patrickalbrecht$ mozregression --good=2013-04-02 --bad=2013-05-13
Downloading nightly from 2013-04-22
Installing nightly
Starting nightly
Was this nightly good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', or 'exit' and press Enter): good
Downloading nightly from 2013-05-02
Installing nightly
Starting nightly
Was this nightly good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', or 'exit' and press Enter): good
Downloading nightly from 2013-05-07
Installing nightly
Starting nightly
Was this nightly good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', or 'exit' and press Enter): good
Downloading nightly from 2013-05-10
Installing nightly
Starting nightly
Was this nightly good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', or 'exit' and press Enter): good
Downloading nightly from 2013-05-11
Installing nightly
Starting nightly
Was this nightly good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', or 'exit' and press Enter): NOTE: child process received `Goodbye', closing down
good
Could not kill process, could not find pid: 474, assuming it's already dead
Downloading nightly from 2013-05-12
Installing nightly
Starting nightly
Was this nightly good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', or 'exit' and press Enter): good


Last good nightly: 2013-05-12
First bad nightly: 2013-05-13

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2013-05-12&enddate=2013-05-13

do you want to bisect further by fetching the repository and building? (y or n) y

By the build from 2013-05-11 I do the mistake and quit firefox before mozregression can do it.

The builds form Step 1 and 2 has the same error.

Comment 12

[u279076]

I'm not sure that's the right range, I only see Android-specific changes:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d68224f5325b&tochange=7130e5134a6e

Can you downoad the 2013-05-12 and 2013-05-13 builds manually and test them to see which one reproduces this issue?

Comment 13

[bugzilla]

I've take 2013-05-12-03-09-08-mozilla-central and 2013-05-13-03-10-57-mozilla-central and by both of it I can Reproduction the bug.

Comment 14

[Edwin Wong [:edwong]]

I figured out this only occurs with specific themes that may not have an icon set for retina displays. The default theme (grey) does not display this issue.

Comment 15

[Edwin Wong [:edwong]]

I can't repro this on some themes.  I'm willing to close this out as an theme bug.

Comment 16

[bugzilla]

Do you mean that the bug are not on the standard theme?
So, I can try this and give you the a feedback.

Comment 17

[bugzilla]

I can confirm, the problem was the theme.