Per UAT there was consensus. 1. Upon voting the share popup should be added to a modal. 2. The modal should have the text "Thanks For Voting" 3. The form should be skinned in a manner so that it looks good in the modal. Gregory please confirm.
I agree with all of the above. If everyone feels comfortable with this, we can go ahead.
If we're talking about a modal in the same way we've done it before on the site (IE black screen that blocks the rest of the site plus a popup box), I think it might be a little disruptive to pop up post-voting. If the user is still watching the video, it'll block their view, and it seems a little aggressive to me to block off the entire page in an attempt to get the user to share the fact that they just voted. Here's an alternative idea: http://cl.ly/image/0r2g0N1l2847 Instead of the modal, we could have that slide out underneath the video when they vote. It's visually similar to the thanks that we gave to people when they uploaded (because I stole it from there!). Just a suggestion, of course. :D
Greg has endorsed comment 2 via IRC, but he wants Holly and Lee to take a look too. Holly, Lee: Thoughts about the mockup from comment 2?
I think the slide out underneath the video would work fine. +1
I think this looks nice and easy to implement, but my only concern is for the user not signed in yet. Will this be a noticeable enough position for the confirmation message? 1. User clicks Vote button 2. Goes through persona sign-in flow 3. Dropped back into this page with the confirmation message under the video, part way down the page. I think it will work just fine, but would like to try it to be sure the page state change is noticeable to this user. It makes sense since it is next to the vote count and would expand nicely for a user who is already signed in.
Testing the current pull request at a few different window sizes, at 1024x768 and up, the box is above the fold. At 800x600, the box is above the fold but not noticeably so. At lower sizes than that it's pretty noticeable as that's when the video starts getting smaller. It's difficult for people using the site in landscape mode as the vertical space we get then is severely reduced. We could make the page scroll down to the notification box when they hit the page after they've voted, but that might be a bit disruptive as it would bring the video out of sight (well, not really, the page isn't tall enough for that, but it'd be shoved up). Does that feel like a good compromise? Changing that behavior post-launch wouldn't be difficult if we find out we don't like it.
When clicking on the vote button, the user is already scrolled down to that point, which is why I am pretty sure the state change will be noticeable enough. If we find that it isn't noticeable after trying it out, then we could auto scroll down to the notification box. It may not be necessary though and may also be more disruptive, as you mentioned. Implement the notification box, and let's try it out. Thanks, mkelly!
Commit pushed to master at https://github.com/mozilla/firefox-flicks https://github.com/mozilla/firefox-flicks/commit/dd01d9789d7b0c813f67d63eede8783e4d4adcf9 Fix bug 898482: Add slide-down share box for post-vote thank you.
Verified on dev. With a smaller height window the voting/sign in process scrolls up to show the top of the video, and the 'Thanks for Voting' does not display unless the user scrolls down [FYI].