898539 - Work - Top site thumbnails don't display if startup pref 'open tabs from last time' is set

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Firefox Start, defect, P1)

Description

[Jim Mathies [:jimm]]

STR:

1) in options, set Startup pref to "tabs from last time"
2) open a web page
3) close
4) reopen

result: web page from step 2 should be loaded

5) open tab bar and close the tab

result: start page loads without top site thumbnails

Comment 1

[Sam Foster [:sfoster] (he/him)]

Confirmed, there must be some init step that isn't taking place if the browser launches displaying another page.

Comment 2

[Asa Dotzler [:asa]]

We either need to fix this or drop the option to start up with tabs from last time. I'm OK with either one.

Comment 3

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Is this also an issue when recovering from a crash? If that's the case then I imagine that we'll want to fix this regardless of whether we keep the "tabs from last time" options

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This was our usual problem with accessing XBL properties before the item was bound (in this case because the Start page was not displayed at startup), with the usual solution.

I'll see if I can come up with a useful test for this bug too.

Comment 5

[Allison Naaktgeboren :ally]

Comment on attachment 782628 [details] [diff] [review]
patch

Review of attachment 782628 [details] [diff] [review]:
-----------------------------------------------------------------

and this is the usual r+ and routine sidelong glare at xbl for this issue.

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fed05531f9e3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fed05531f9e3