Closed
Bug 898539
Opened 12 years ago
Closed 12 years ago
Work - Top site thumbnails don't display if startup pref 'open tabs from last time' is set
Categories
(Firefox for Metro Graveyard :: Firefox Start, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: jimm, Assigned: mbrubeck)
References
Details
(Whiteboard: feature=work)
Attachments
(1 file)
1.83 KB,
patch
|
ally
:
review+
|
Details | Diff | Splinter Review |
STR:
1) in options, set Startup pref to "tabs from last time"
2) open a web page
3) close
4) reopen
result: web page from step 2 should be loaded
5) open tab bar and close the tab
result: start page loads without top site thumbnails
Updated•12 years ago
|
Summary: Top site thumbnails don't display if startup pref 'open tabs from last time' is set → Defect - Top site thumbnails don't display if startup pref 'open tabs from last time' is set
Whiteboard: feature=defect c=tbd u=tbd p=0
Comment 1•12 years ago
|
||
Confirmed, there must be some init step that isn't taking place if the browser launches displaying another page.
Comment 2•12 years ago
|
||
We either need to fix this or drop the option to start up with tabs from last time. I'm OK with either one.
Priority: -- → P1
Updated•12 years ago
|
Blocks: 831920
Whiteboard: feature=defect c=tbd u=tbd p=0 → feature=defect c=firefox_start u=tbd p=0
Updated•12 years ago
|
No longer blocks: metrov1defect&change
Whiteboard: feature=defect c=firefox_start u=tbd p=0 → feature=defect
Updated•12 years ago
|
Blocks: metrov1defect&change
Whiteboard: feature=defect → feature=defect c=firefox_start u=tbd p=0
Updated•12 years ago
|
No longer blocks: metrov1defect&change
Summary: Defect - Top site thumbnails don't display if startup pref 'open tabs from last time' is set → Work - Top site thumbnails don't display if startup pref 'open tabs from last time' is set
Whiteboard: feature=defect c=firefox_start u=tbd p=0 → feature=work
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Comment 3•12 years ago
|
||
Is this also an issue when recovering from a crash? If that's the case then I imagine that we'll want to fix this regardless of whether we keep the "tabs from last time" options
Assignee | ||
Comment 4•12 years ago
|
||
This was our usual problem with accessing XBL properties before the item was bound (in this case because the Start page was not displayed at startup), with the usual solution.
I'll see if I can come up with a useful test for this bug too.
Attachment #782628 -
Flags: review?(ally)
Comment 5•12 years ago
|
||
Comment on attachment 782628 [details] [diff] [review]
patch
Review of attachment 782628 [details] [diff] [review]:
-----------------------------------------------------------------
and this is the usual r+ and routine sidelong glare at xbl for this issue.
Attachment #782628 -
Flags: review?(ally) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Updated•11 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•