Closed
Bug 89854
Opened 24 years ago
Closed 23 years ago
netscape 4.x profile migration dialog doesn't fit on 640x480 screen
Categories
(Core Graveyard :: Profile: BackEnd, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.4
People
(Reporter: blizzard, Assigned: ccarlen)
References
Details
Attachments
(4 files)
7.24 KB,
patch
|
Details | Diff | Splinter Review | |
837 bytes,
patch
|
Details | Diff | Splinter Review | |
23.39 KB,
image/gif
|
Details | |
7.08 KB,
patch
|
Details | Diff | Splinter Review |
From Alan:
"Run netscape, quit, run mozilla for the first time on a 640x480 display and
the dialog is not all visible."
Does anyone feel like rogering that dialog so that it isn't long as hell? It
should be cleaned up.
Comment 1•24 years ago
|
||
This shouldn't be a special xul window at all, it just needs to be a regular
prompt with special strings for the buttons. This is thrown from the backend.
-> backend
Assignee: ben → ccarlen
Component: Profile Manager FrontEnd → Profile Manager BackEnd
Assignee | ||
Comment 2•24 years ago
|
||
Fully agree. It should just be a nsIPromptService::ConfirmEx. How is it possible
with commonDialogs, which are used for that, to have the width of the static
text field fixed, the text flowed into it, and it would grow vertically. There's
all kinds of dialogs done in wallet where linebreaks are inserted in the
properties file to avoid the wide dialog. Whenever those things are localized,
these linebreaks have to be redone by hand. Can't we set up the XUL of
commonDialogs to avoid this?
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•24 years ago
|
||
Assignee | ||
Comment 4•24 years ago
|
||
Using nsIPromptService to do this makes the text wrap nicely so the fixed width
of the dialog. It also cleans up some odd logic in the back-end and another set
of .xul/.js files can be removed from the profile resources.
Assignee | ||
Comment 6•24 years ago
|
||
Assignee | ||
Comment 7•24 years ago
|
||
The first patch removed some things from migration.properties that it shouldn't
have.
Assignee | ||
Comment 8•24 years ago
|
||
Bhuvan - Can you r=? Ben or Blake sr=?
Assignee | ||
Comment 10•23 years ago
|
||
Assignee | ||
Comment 12•23 years ago
|
||
Assignee | ||
Comment 13•23 years ago
|
||
The slightly better patch uses unicode linefeed chars in the properties file
instead of using '#' chars an converting those to linefeeds in the C++.
Assignee | ||
Comment 14•23 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•