netscape 4.x profile migration dialog doesn't fit on 640x480 screen

VERIFIED FIXED in mozilla0.9.4

Status

VERIFIED FIXED
18 years ago
3 years ago

People

(Reporter: blizzard, Assigned: ccarlen)

Tracking

Trunk
mozilla0.9.4
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

18 years ago
From Alan:

"Run netscape, quit, run mozilla for the first time on a 640x480 display and
the dialog is not all visible."

Does anyone feel like rogering that dialog so that it isn't long as hell?  It
should be cleaned up.

Comment 1

18 years ago
This shouldn't be a special xul window at all, it just needs to be a regular 
prompt with special strings for the buttons.  This is thrown from the backend. 
-> backend
Assignee: ben → ccarlen
Component: Profile Manager FrontEnd → Profile Manager BackEnd
(Assignee)

Comment 2

18 years ago
Fully agree. It should just be a nsIPromptService::ConfirmEx. How is it possible
with commonDialogs, which are used for that, to have the width of the static
text field fixed, the text flowed into it, and it would grow vertically. There's
all kinds of dialogs done in wallet where linebreaks are inserted in the
properties file to avoid the wide dialog. Whenever those things are localized,
these linebreaks have to be redone by hand. Can't we set up the XUL of
commonDialogs to avoid this?
Status: NEW → ASSIGNED
(Assignee)

Comment 3

18 years ago
Created attachment 43625 [details] [diff] [review]
patch to do dialog with nsIPromptService
(Assignee)

Comment 4

18 years ago
Using nsIPromptService to do this makes the text wrap nicely so the fixed width
of the dialog. It also cleans up some odd logic in the back-end and another set
of .xul/.js files can be removed from the profile resources.
(Assignee)

Comment 5

18 years ago
-> 0.9.4
Target Milestone: --- → mozilla0.9.4
(Assignee)

Comment 6

18 years ago
Created attachment 43792 [details] [diff] [review]
fixed patch to migration.properties
(Assignee)

Comment 7

18 years ago
The first patch removed some things from migration.properties that it shouldn't
have.

Updated

18 years ago
Blocks: 81153
(Assignee)

Comment 8

17 years ago
Bhuvan - Can you r=? Ben or Blake sr=?

Comment 9

17 years ago
looks good. r=racham.

Conrad, please do post a screen shot. thanks.
(Assignee)

Comment 10

17 years ago
Created attachment 46710 [details]
screenshot of new dialog on 640 x 480 screen
(Assignee)

Comment 12

17 years ago
Created attachment 46713 [details] [diff] [review]
slightly better patch
(Assignee)

Comment 13

17 years ago
The slightly better patch uses unicode linefeed chars in the properties file
instead of using '#' chars an converting those to linefeeds in the C++.
(Assignee)

Comment 14

17 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 15

17 years ago
verified in build 2001082808
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.