change the screen resolution for helix builds

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: atsai, Assigned: joduinn)

Tracking

other
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:hd+, b2g18 unaffected, b2g-v1.1hd fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Currently, the gaia.zip and the helix.zip use the 1.0 ratio pictures and we should change them to 1.5 ratio to support hd devices.
Please change the build script with GAIA_DEV_PIXELS_PER_PX to 1.5x.
The way we make the build is by set the GAIA_DEV_PIXELS_PER_PX=1.5 and then call the make function. You can reference the following link for more information.

https://wiki.mozilla.org/B2G/QA/Tips_And_Tricks#Hi_DPI_builds
(Reporter)

Updated

5 years ago
Blocks: 896858
Found in triage. Not sure if this belongs in Automation, or in PlatformSupport, so starting with Automation first...
Component: Release Engineering → Release Engineering: Automation (General)
QA Contact: catlee
If this is just an environment variable, it can be set in the appropriate config.json file, e.g.
https://hg.mozilla.org/releases/mozilla-b2g18/file/default/b2g/config/unagi/config.json#l22

Which builds are for helix?
(Reporter)

Comment 3

5 years ago
(In reply to Chris AtLee [:catlee] from comment #2)
> If this is just an environment variable, it can be set in the appropriate
> config.json file, e.g.
> https://hg.mozilla.org/releases/mozilla-b2g18/file/default/b2g/config/unagi/
> config.json#l22
> 
> Which builds are for helix?

v1.1.0hd
which device? unagi? leo? inari?
nm, we have a 'helix' build!
(Reporter)

Comment 6

5 years ago
Sorry for misleading. Allow me to brief it a little bit.

For now, QA test on Helix devices with the base build from partners and flash Mozilla gaia/gecko on it. QA will download the gaia and gecko from https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-b2g18_v1_1_0_hd-helix/latest/

Due to the hd-helix support WVGA, the pictures we use should be @1.5x compare to origin. To simply check the version we have, the images in webapps/app.gaiamobile.org/style/images/ should be the same size as in gaia repo.

For example, unzip gaia/webapps/settings.gaiamobile.org/application.zip. The application/style/images/bluetooth_sprite.png should be 33kb, and it's 19kb now, which means we are having run build script for the pvt build.

To have the correct build, we'll need to add GAIA_DEV_PIXELS_PER_PX=1.5 before "make gaia" command.
Just had quick irc chat w/atsai, which helped untangle the confusion here. To clarify:

1) This change is for helix device builds only. These helix builds are currently only being generated on the v1.1.0hd branch.

2) Setting the environment variable GAIA_DEV_PIXELS_PER_PX to the value "1.5" before starting the build should generate the helix builds with the desired resolution.

3) Specifically, setting this variable in https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/file/86dcde12a3f3/b2g/config/helix/config.json would do the trick. Atsai is trying a local build with change I sent him in irc, and he can then look at the build on an actual helix device to verify that the resolution is now changed. Atsai will update here in this bug with results of his local-build-experiment.

Meanwhile, I'll whip up the one-liner patch for formal r?.
Created attachment 782992 [details] [diff] [review]
change helix resolution in b2g/config/helix/config.json

note: we only generate these helix builds on mozilla-b2g18_v1_1_0_hd
Attachment #782992 - Flags: review?(catlee)
Summary: We need to change the resolution for helix build on pvt → change the screen resolution for helix builds

Updated

5 years ago
Attachment #782992 - Flags: review?(catlee) → review+
(Reporter)

Comment 9

5 years ago
Hi joduinn, it seems not a big deal but I still prefer to set the "b2g_manifest_branch": "v1-train",to "b2g_manifest_branch": "v1.1.0hd",

It will be easier to modify settings on the correct branch. Please change that if it's not too bothering. It seems good on my local build and I am looking forward to a pvt build for checking. Thanks.
(In reply to Al Tsai [:atsai] from comment #9)
> Hi joduinn, it seems not a big deal but I still prefer to set the
> "b2g_manifest_branch": "v1-train",to "b2g_manifest_branch": "v1.1.0hd",
> 
> It will be easier to modify settings on the correct branch. Please change
> that if it's not too bothering. It seems good on my local build and I am
> looking forward to a pvt build for checking. Thanks.

Sure, that's an easy change to that file as well. Is that related to the screen resolution at all, or is it a separate unrelated request?
Marking this as hd+ and affected to get it uplifted to v1.1hd branch.  Will also need to land on b2g18.
blocking-b2g: --- → hd+
status-b2g18: --- → affected
status-b2g-v1.1hd: --- → affected
https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/aa9efc2f9886

This file doesn't exist in mozilla-b2g18 so marking it unaffected.
status-b2g18: affected → unaffected
status-b2g-v1.1hd: affected → fixed
(Reporter)

Comment 13

5 years ago
(In reply to Chris AtLee [:catlee] from comment #10)
> (In reply to Al Tsai [:atsai] from comment #9)
> > Hi joduinn, it seems not a big deal but I still prefer to set the
> > "b2g_manifest_branch": "v1-train",to "b2g_manifest_branch": "v1.1.0hd",
> > 
> > It will be easier to modify settings on the correct branch. Please change
> > that if it's not too bothering. It seems good on my local build and I am
> > looking forward to a pvt build for checking. Thanks.
> 
> Sure, that's an easy change to that file as well. Is that related to the
> screen resolution at all, or is it a separate unrelated request?

Sorry for late reply. It doesn't related to the screen resolution but affect the overall settings. As you read in the b2g_manifest redirect the build step to download correct branches to build. Some might be affected in the future if we only modify some files in v1.1.0hd branch (for now, they should be the same). I believe it related to the gonk and other manifest used for building correct helix builds.
(In reply to Al Tsai [:atsai] from comment #13)
> (In reply to Chris AtLee [:catlee] from comment #10)
> > (In reply to Al Tsai [:atsai] from comment #9)
> > > Hi joduinn, it seems not a big deal but I still prefer to set the
> > > "b2g_manifest_branch": "v1-train",to "b2g_manifest_branch": "v1.1.0hd",
> > > 
> > > It will be easier to modify settings on the correct branch. Please change
> > > that if it's not too bothering. It seems good on my local build and I am
> > > looking forward to a pvt build for checking. Thanks.
> > 
> > Sure, that's an easy change to that file as well. Is that related to the
> > screen resolution at all, or is it a separate unrelated request?
> 
> Sorry for late reply. It doesn't related to the screen resolution but affect
> the overall settings. As you read in the b2g_manifest redirect the build
> step to download correct branches to build. Some might be affected in the
> future if we only modify some files in v1.1.0hd branch (for now, they should
> be the same). I believe it related to the gonk and other manifest used for
> building correct helix builds.

atsai: 
1) Good catch! I've filed bug#899895 to track fixing "b2g_manifest_branch". 

2) As the work in *this* bug for screen resolution is now done, and landed in production, for all relevant branches, so I think we're done here. I'll close this for now, but if you find any problems with the resolution on helix builds, please reopen with details, ok?
Assignee: nobody → joduinn
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 15

5 years ago
Sure. Thanks for help
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.