Closed
Bug 898621
Opened 11 years ago
Closed 11 years ago
Make ToClampedIndex take a HandleValue
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.01 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Now that CallArgs::operator[] returns HandleValue, this is zero cost and kills a huge number of unsafe reference warnings.
Attachment #781920 -
Flags: review?(sphink)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 781920 [details] [diff] [review] to_clamped_index_use_handle-v0.dif Review of attachment 781920 [details] [diff] [review]: ----------------------------------------------------------------- This is so clearly wrong that I can't believe you would be idiotic enough to... never mind, just kidding, this is awesome. That operator[] just keeps on giving!
Attachment #781920 -
Flags: review?(sphink) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/41730f142283
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/41730f142283
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•