898640 - remove graphs.m.o index, redirect to graphs.html instead

Status: RESOLVED FIXED

(Webtools Graveyard :: Graph Server, defect)

Description

[Robert Helmer [:rhelmer]]

Per discussion in bug 641413 comment 12, let's remove the index page since it's not being maintained and it's preventing bug 641413 from being deployed.

Comment 1

[Matthew N. [:MattN]]

How about we just have this bug to track fixing it and just go ahead and deploy the new code since it was already mostly broken. I actually do think it's useful and would add it to the rotation of tabs displayed on a dashboard in MV. I think the work to remove this is more effort than fixing it. If you want to put a Redirect in the .htaccess for now then I don't mind that.

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Matthew N. [:MattN] from comment #1)
> How about we just have this bug to track fixing it and just go ahead and
> deploy the new code since it was already mostly broken. I actually do think
> it's useful and would add it to the rotation of tabs displayed on a
> dashboard in MV. I think the work to remove this is more effort than fixing
> it. If you want to put a Redirect in the .htaccess for now then I don't mind
> that.

This all sounds good to me! I was thinking of redirecting in .htaccess

I'll just go ahead and do that now, if you come along with a user-configurable dashboard we can always remove the redirect and drop that back in (can track that in a new bug)

Comment 3

[Robert Helmer [:rhelmer]]

OK added this to dist.htaccess:

DirectoryIndex graph.html

default branch:
https://hg.mozilla.org/graphs/file/64476a043e08

2_3-branch:
https://hg.mozilla.org/graphs/file/03891f58c2d1

Comment 4

[Matthew N. [:MattN]]

(In reply to Robert Helmer [:rhelmer] from comment #3)
> DirectoryIndex graph.html

Can you do a redirect instead so URLs won't break if we re-enabled the homepage at some point?

Comment 5

[Robert Helmer [:rhelmer]]

(In reply to Matthew N. [:MattN] from comment #4)
> (In reply to Robert Helmer [:rhelmer] from comment #3)
> > DirectoryIndex graph.html
> 
> Can you do a redirect instead so URLs won't break if we re-enabled the
> homepage at some point?

Sure, good point.. I'll do a temporary redirect instead

Comment 6

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #5)
> (In reply to Matthew N. [:MattN] from comment #4)
> > (In reply to Robert Helmer [:rhelmer] from comment #3)
> > > DirectoryIndex graph.html
> > 
> > Can you do a redirect instead so URLs won't break if we re-enabled the
> > homepage at some point?
> 
> Sure, good point.. I'll do a temporary redirect instead

How do you feel about:

Redirect 302 / http://graphs.mozilla.org/graph.html

?

Comment 7

[Robert Helmer [:rhelmer]]

(see comment 6)

Comment 8

[Matthew N. [:MattN]]

(In reply to Robert Helmer [:rhelmer] from comment #6)
> (In reply to Robert Helmer [:rhelmer] from comment #5)
> > (In reply to Matthew N. [:MattN] from comment #4)
> > > (In reply to Robert Helmer [:rhelmer] from comment #3)
> > > > DirectoryIndex graph.html
> > > 
> > > Can you do a redirect instead so URLs won't break if we re-enabled the
> > > homepage at some point?
> > 
> > Sure, good point.. I'll do a temporary redirect instead
> 
> How do you feel about:
> 
> Redirect 302 / http://graphs.mozilla.org/graph.html

My understanding is that will redirect everything to that URL and would cause an infinite loop because Redirect does prefix matching.

I think you want something like:
RedirectMatch 302 ^/?$ /graph.html

Comment 9

[Robert Helmer [:rhelmer]]

Oh right you are! Thanks for catching that, I have pushed this change to stage now (graphs.allizom.org)