898653 - Lots of warnings 'C4003' when compiling on MSVC - not enough actual parameters for macro 'MOZ_ASSUME_UNREACHABLE'

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

These seem to mostly come from YarrParser.h but I've also seen some in YarrCanonicalizeUCS2.h

Comment 1

[Till Schneidereit [:till]]

Attachment: Quell 'not enough parameters for macro' warnings in MSVC

Most of the warnings are from Yarr and can be fixed by changing our definition of Yarr's ASSERT_NOT_REACHED. The same holds for the blink-imported Decimal stuff, too. That's in MFBT, but I don't think Waldo has to review that.

The only location where we're really missing a reason is in IonCaches.cpp. I hope the one I added makes sense.

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 782136 [details] [diff] [review]
Quell 'not enough parameters for macro' warnings in MSVC

Review of attachment 782136 [details] [diff] [review]:
-----------------------------------------------------------------

Comments are just suggestions, your call.

::: js/src/assembler/wtf/Assertions.h
@@ +43,5 @@
>  #define ASSERT_UNUSED(variable, assertion) do { \
>      (void)variable; \
>      ASSERT(assertion); \
>  } while (0)
> +#define ASSERT_NOT_REACHED() MOZ_ASSUME_UNREACHABLE("")

MOZ_ASSUME_UNREACHABLE("Assertions.h"), maybe?

::: mfbt/decimal/moz-decimal-utils.h
@@ +31,5 @@
>  #undef ASSERT
>  #endif
>  #define ASSERT MOZ_ASSERT
>  
> +#define ASSERT_NOT_REACHED() MOZ_ASSUME_UNREACHABLE("")

MOZ_ASSUME_UNREACHABLE("moz-decimal-utils.h"), maybe?

Comment 3

[Till Schneidereit [:till]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/752a6805b83b

Thanks for the review. I went with "wtf/Assertions.h", because we have multiple files with that name.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/752a6805b83b