898660 - Sqlite3 compilation error on Mac OS X 10.7 or newer w/ Xcode 4.5 or newer

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: fix_sqlite_error.patch

STR: 1. download b2g, try to compile on 10.7 or newer w/ Xcode 4.5 or newer

Expected: compiles
Actual: 
ld: symbol(s) not found for architecture i386
collect2: ld returned 1 exit status
make: *** [out/host/darwin-x86/obj/EXECUTABLES/sqlite3_intermediates/sqlite3] Error 1

Note: 
1. solution from :  https://groups.google.com/forum/#!msg/android-building/yAfPyUqCsiQ/7zvICk4GWjYJ seems to work.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Note: /external/sqlite/dist/Android.mk needs to be modified w/ the patch.

Comment 2

[Justin Lebar (not reading bugmail)]

Comment on attachment 781984 [details] [diff] [review]
fix_sqlite_error.patch

Mike, is this a repository we can patch?

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

mwu, review ping?

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

I ran into this today.  I'm guessing the patch would need to go into our /patches infrastructure to apply the patch after repo sync completes?

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

It looks like our patch support is only on a device-by-device basis.  There is no way at the moment to say "apply this patch for all devices".  So this patch would either need to be duplicated for each device or the patcher script would need to be updated to accept an additional "all" parameter for device.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Ben Kelly [:bkelly] from comment #5)
> It looks like our patch support is only on a device-by-device basis.  There
> is no way at the moment to say "apply this patch for all devices".  So this
> patch would either need to be duplicated for each device or the patcher
> script would need to be updated to accept an additional "all" parameter for
> device.

Actually, I'm completely wrong here.  The script looks for a patches/all directory that applies to all devices.  Sorry for my confusion.

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

And talking to mwu the patch scripts that work off the gonk-patches repository is being deprecated.  Its also only for vendor patches.  So this can't go through that path.

From what mwu says, correct fix here is to fork the sqlite repo and it needs to be done in coordination with releng.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

To note, the patch that I placed in here should be applied to the github repo that you have in the <project folder>/external/sqlite/

ie : 
cd <project folder>/external/sqlite
git checkout -b master (in case you need to revert)
git checkout -b sqlitefix
git apply fix_sqlite_error.patch

So the patch applying should be simple?  It hasn't seem to change as of yet.

Comment 9

[BMO Automation]

Firefox OS is not being worked on