Persona is no longer an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 898683 - Context menu for .eml files is broken
: Context menu for .eml files is broken
: regression
Product: Thunderbird
Classification: Client Software
Component: Message Reader UI (show other bugs)
: 24 Branch
: All All
: -- normal (vote)
: Thunderbird 26.0
Assigned To: Jim Porter (:squib)
Depends on:
Blocks: 179033
  Show dependency treegraph
Reported: 2013-07-26 16:39 PDT by Jim Porter (:squib)
Modified: 2013-08-12 08:19 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Fix this (1.61 KB, patch)
2013-07-26 16:52 PDT, Jim Porter (:squib)
mkmelin+mozilla: review+
standard8: approval‑comm‑aurora+
standard8: approval‑comm‑beta+
Details | Diff | Splinter Review

Description Jim Porter (:squib) 2013-07-26 16:39:11 PDT
This is fallout from bug 179033. Opening an .eml file throws the following error, which (among other things?) breaks the context menu so everything is shown:

Error: TypeError: message.folder is null
Source File: chrome://messenger/content/folderDisplay.js
Line: 1956

We need to make sure the message is not external before using message.folder.
Comment 1 Jim Porter (:squib) 2013-07-26 16:52:26 PDT
Created attachment 782033 [details] [diff] [review]
Fix this

Here's a quick fix for it.
Comment 2 Magnus Melin 2013-08-01 11:27:07 PDT
Comment on attachment 782033 [details] [diff] [review]
Fix this

Review of attachment 782033 [details] [diff] [review]:

Thx for the fix! r=mkmelin
Comment 3 Mark Banner (:standard8) 2013-08-12 02:50:21 PDT
So I think because bug 179033 got backed out, this doesn't need to be in TB 24?
Comment 4 Magnus Melin 2013-08-12 03:24:33 PDT
(In reply to Mark Banner (:standard8) from comment #3)
> So I think because bug 179033 got backed out, this doesn't need to be in TB
> 24?

No, bug 179033 landed for tb24, it's just open because i wanted to figure out the test (which is awaiting review from you).

So this is needed for tb24.
Comment 5 Mark Banner (:standard8) 2013-08-12 07:42:51 PDT
I've pushed this so we can get it in for the upcoming beta:
Comment 6 Mark Banner (:standard8) 2013-08-12 07:44:20 PDT
Comment on attachment 782033 [details] [diff] [review]
Fix this

[Triage Comment]
a=me as this is a regression fix.

Note You need to log in before you can comment on or make changes to this bug.