Closed Bug 898683 Opened 8 years ago Closed 8 years ago

Context menu for .eml files is broken

Categories

(Thunderbird :: Message Reader UI, defect)

24 Branch
defect
Not set
normal

Tracking

(thunderbird24+ fixed, thunderbird25 fixed)

RESOLVED FIXED
Thunderbird 26.0
Tracking Status
thunderbird24 + fixed
thunderbird25 --- fixed

People

(Reporter: squib, Assigned: squib)

References

Details

(Keywords: regression)

Attachments

(1 file)

This is fallout from bug 179033. Opening an .eml file throws the following error, which (among other things?) breaks the context menu so everything is shown:

Error: TypeError: message.folder is null
Source File: chrome://messenger/content/folderDisplay.js
Line: 1956

We need to make sure the message is not external before using message.folder.
Hardware: x86_64 → All
Version: unspecified → 24
Attached patch Fix thisSplinter Review
Here's a quick fix for it.
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED
Attachment #782033 - Flags: review?(mkmelin+mozilla)
Comment on attachment 782033 [details] [diff] [review]
Fix this

Review of attachment 782033 [details] [diff] [review]:
-----------------------------------------------------------------

Thx for the fix! r=mkmelin
Attachment #782033 - Flags: review?(mkmelin+mozilla) → review+
Keywords: regression
OS: Linux → All
So I think because bug 179033 got backed out, this doesn't need to be in TB 24?
(In reply to Mark Banner (:standard8) from comment #3)
> So I think because bug 179033 got backed out, this doesn't need to be in TB
> 24?

No, bug 179033 landed for tb24, it's just open because i wanted to figure out the test (which is awaiting review from you).

So this is needed for tb24.
I've pushed this so we can get it in for the upcoming beta:

https://hg.mozilla.org/comm-central/rev/05296139dcd0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
Comment on attachment 782033 [details] [diff] [review]
Fix this

[Triage Comment]
a=me as this is a regression fix.
Attachment #782033 - Flags: approval-comm-beta+
Attachment #782033 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.