898683 - Context menu for .eml files is broken

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Jim Porter (:squib)]

This is fallout from bug 179033. Opening an .eml file throws the following error, which (among other things?) breaks the context menu so everything is shown:

Error: TypeError: message.folder is null
Source File: chrome://messenger/content/folderDisplay.js
Line: 1956

We need to make sure the message is not external before using message.folder.

Comment 1

[Jim Porter (:squib)]

Attachment: Fix this

Here's a quick fix for it.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 782033 [details] [diff] [review]
Fix this

Review of attachment 782033 [details] [diff] [review]:
-----------------------------------------------------------------

Thx for the fix! r=mkmelin

Comment 3

[Mark Banner (:standard8)]

So I think because bug 179033 got backed out, this doesn't need to be in TB 24?

Comment 4

[Magnus Melin [:mkmelin]]

(In reply to Mark Banner (:standard8) from comment #3)
> So I think because bug 179033 got backed out, this doesn't need to be in TB
> 24?

No, bug 179033 landed for tb24, it's just open because i wanted to figure out the test (which is awaiting review from you).

So this is needed for tb24.

Comment 5

[Mark Banner (:standard8)]

I've pushed this so we can get it in for the upcoming beta:

https://hg.mozilla.org/comm-central/rev/05296139dcd0

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 782033 [details] [diff] [review]
Fix this

[Triage Comment]
a=me as this is a regression fix.

Comment 7

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/3163066a4f54
https://hg.mozilla.org/releases/comm-beta/rev/31e202c7c583