Closed Bug 898687 Opened 6 years ago Closed 6 years ago

Remove XULTreeBuilder from content

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: bruant.d, Assigned: emk)

References

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(2 files)

I can observe the XULTreeBuilder constructor in Aurora ans Nightly. This is Mozilla-specific and should probably be hidden. There might be others. Is this related to the WebIDL binding work?
The easiest way would be converting this interface to WebIDL and marking it as [ChromeOnly].
Jan, why did this need classinfo?
Flags: needinfo?(Jan.Varga)
It was added to simplify access to tree views from JS (interface flattening), bug 202393
Flags: needinfo?(Jan.Varga)
https://tbpl.mozilla.org/?tree=Try&rev=8e43806984c1
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #782299 - Flags: review?(Jan.Varga)
Comment on attachment 782307 [details] [diff] [review]
Test to make sure XUL classes are hidden from content

test_interfaces.html change needs DOM peer's approval.
Attachment #782307 - Flags: review?(bugs)
Comment on attachment 782307 [details] [diff] [review]
Test to make sure XUL classes are hidden from content

yes!
Attachment #782307 - Flags: review?(bugs) → review+
Comment on attachment 782299 [details] [diff] [review]
Hide XUL related classes from content

Review of attachment 782299 [details] [diff] [review]:
-----------------------------------------------------------------

looks good
Attachment #782299 - Flags: review?(Jan.Varga) → review+
Attachment #782307 - Flags: review?(Jan.Varga) → review+
I also noticed XULElement and ChromeWindow. Should I file another bug? (sorry for not telling earler :-s)
Looking at the patch, I noticed the dom/tests/mochitest/general/test_interfaces.html file and the following comment at the top: 
// This is a list of all interfaces that are exposed to every webpage.  Please only
// add things to this list with great care.

So I guess all the ones at the bottom starting with XUL could be removed too?
Many of those interfaces (including ChromeWindow and XULElement) cannot be removed until bug 898817 is fixed. So I left them for now.
Depends on: 898817
(In reply to Masatoshi Kimura [:emk] from comment #11)
> Many of those interfaces (including ChromeWindow and XULElement) cannot be
> removed until bug 898817 is fixed. So I left them for now.
Sounds good. I'll file a followup bug that depends on bug 898817.
No longer depends on: 898817
(sorr for the conflict)
Depends on: 898817
(Are there any people still using remote XUL? If so, would this affect them?)
https://hg.mozilla.org/mozilla-central/rev/ebf4605b082f
https://hg.mozilla.org/mozilla-central/rev/ec9d11a89ba4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.