Remove XULTreeBuilder from content

RESOLVED FIXED in mozilla25

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: David Bruant, Assigned: emk)

Tracking

({dev-doc-complete, site-compat})

unspecified
mozilla25
dev-doc-complete, site-compat
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
I can observe the XULTreeBuilder constructor in Aurora ans Nightly. This is Mozilla-specific and should probably be hidden. There might be others. Is this related to the WebIDL binding work?
(Assignee)

Comment 1

4 years ago
The easiest way would be converting this interface to WebIDL and marking it as [ChromeOnly].
Jan, why did this need classinfo?
Flags: needinfo?(Jan.Varga)

Comment 3

4 years ago
It was added to simplify access to tree views from JS (interface flattening), bug 202393
Flags: needinfo?(Jan.Varga)
(Assignee)

Comment 4

4 years ago
Created attachment 782299 [details] [diff] [review]
Hide XUL related classes from content

https://tbpl.mozilla.org/?tree=Try&rev=8e43806984c1
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #782299 - Flags: review?(Jan.Varga)
(Assignee)

Comment 5

4 years ago
Created attachment 782307 [details] [diff] [review]
Test to make sure XUL classes are hidden from content
Attachment #782307 - Flags: review?(Jan.Varga)
(Assignee)

Comment 6

4 years ago
Comment on attachment 782307 [details] [diff] [review]
Test to make sure XUL classes are hidden from content

test_interfaces.html change needs DOM peer's approval.
Attachment #782307 - Flags: review?(bugs)

Comment 7

4 years ago
Comment on attachment 782307 [details] [diff] [review]
Test to make sure XUL classes are hidden from content

yes!
Attachment #782307 - Flags: review?(bugs) → review+

Comment 8

4 years ago
Comment on attachment 782299 [details] [diff] [review]
Hide XUL related classes from content

Review of attachment 782299 [details] [diff] [review]:
-----------------------------------------------------------------

looks good
Attachment #782299 - Flags: review?(Jan.Varga) → review+

Updated

4 years ago
Attachment #782307 - Flags: review?(Jan.Varga) → review+
(Reporter)

Comment 9

4 years ago
I also noticed XULElement and ChromeWindow. Should I file another bug? (sorry for not telling earler :-s)
(Reporter)

Comment 10

4 years ago
Looking at the patch, I noticed the dom/tests/mochitest/general/test_interfaces.html file and the following comment at the top: 
// This is a list of all interfaces that are exposed to every webpage.  Please only
// add things to this list with great care.

So I guess all the ones at the bottom starting with XUL could be removed too?
(Assignee)

Comment 11

4 years ago
Many of those interfaces (including ChromeWindow and XULElement) cannot be removed until bug 898817 is fixed. So I left them for now.
(Assignee)

Updated

4 years ago
Depends on: 898817
(Reporter)

Comment 12

4 years ago
(In reply to Masatoshi Kimura [:emk] from comment #11)
> Many of those interfaces (including ChromeWindow and XULElement) cannot be
> removed until bug 898817 is fixed. So I left them for now.
Sounds good. I'll file a followup bug that depends on bug 898817.
No longer depends on: 898817
(Reporter)

Comment 13

4 years ago
(sorr for the conflict)
Depends on: 898817
(Assignee)

Comment 14

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebf4605b082f
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec9d11a89ba4
Flags: in-testsuite+
(Are there any people still using remote XUL? If so, would this affect them?)
https://hg.mozilla.org/mozilla-central/rev/ebf4605b082f
https://hg.mozilla.org/mozilla-central/rev/ec9d11a89ba4
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Added to the site compatibility doc just in case:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility
Keywords: dev-doc-complete, site-compat
You need to log in before you can comment on or make changes to this bug.