898687 - Remove XULTreeBuilder from content

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Bruant]

I can observe the XULTreeBuilder constructor in Aurora ans Nightly. This is Mozilla-specific and should probably be hidden. There might be others. Is this related to the WebIDL binding work?

Comment 1

[Masatoshi Kimura [:emk]]

The easiest way would be converting this interface to WebIDL and marking it as [ChromeOnly].

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Jan, why did this need classinfo?

Comment 3

[Jan Varga [:janv]]

It was added to simplify access to tree views from JS (interface flattening), bug 202393

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Hide XUL related classes from content

https://tbpl.mozilla.org/?tree=Try&rev=8e43806984c1

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: Test to make sure XUL classes are hidden from content

Comment 6

[Masatoshi Kimura [:emk]]

Comment on attachment 782307 [details] [diff] [review]
Test to make sure XUL classes are hidden from content

test_interfaces.html change needs DOM peer's approval.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 782307 [details] [diff] [review]
Test to make sure XUL classes are hidden from content

yes!

Comment 8

[Jan Varga [:janv]]

Comment on attachment 782299 [details] [diff] [review]
Hide XUL related classes from content

Review of attachment 782299 [details] [diff] [review]:
-----------------------------------------------------------------

looks good

Comment 9

[David Bruant]

I also noticed XULElement and ChromeWindow. Should I file another bug? (sorry for not telling earler :-s)

Comment 10

[David Bruant]

Looking at the patch, I noticed the dom/tests/mochitest/general/test_interfaces.html file and the following comment at the top: 
// This is a list of all interfaces that are exposed to every webpage.  Please only
// add things to this list with great care.

So I guess all the ones at the bottom starting with XUL could be removed too?

Comment 11

[Masatoshi Kimura [:emk]]

Many of those interfaces (including ChromeWindow and XULElement) cannot be removed until bug 898817 is fixed. So I left them for now.

Comment 12

[David Bruant]

(In reply to Masatoshi Kimura [:emk] from comment #11)
> Many of those interfaces (including ChromeWindow and XULElement) cannot be
> removed until bug 898817 is fixed. So I left them for now.
Sounds good. I'll file a followup bug that depends on bug 898817.

Comment 13

[David Bruant]

(sorr for the conflict)

Comment 14

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ebf4605b082f
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec9d11a89ba4

Comment 15

[[e-mail]]

(Are there any people still using remote XUL? If so, would this affect them?)

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ebf4605b082f
https://hg.mozilla.org/mozilla-central/rev/ec9d11a89ba4

Comment 17

[Kohei Yoshino]

Added to the site compatibility doc just in case:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility