Closed Bug 898715 Opened 11 years ago Closed 11 years ago

land script.py changes from beagle branch

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mozilla, Assigned: mozilla)

References

Details

(Whiteboard: [mozharness])

Attachments

(1 file)

The script.py changes here:
https://github.com/escapewindow/mozharness/compare/master...beagle

This should make the beagle review smoother.
Attached patch scriptSplinter Review
Sorry, and thanks, about all the reviews.

This patch:

* catches shutil.Error in move()
* updates run_command():
** gets rid of unused parse_at_end (we can use get_output_from_command() with an OutputParser for this)
** updates TODOs
** adds partial_env support, which is less spammy than printing the entire env every time.
** prints env (or partial_env), which we've wanted for a while.
* plus some pep8 changes.
Attachment #786071 - Flags: review?(rail)
Attachment #786071 - Flags: review?(rail) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: