Closed
Bug 898715
Opened 12 years ago
Closed 12 years ago
land script.py changes from beagle branch
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mozilla, Assigned: mozilla)
References
Details
(Whiteboard: [mozharness])
Attachments
(1 file)
|
8.68 KB,
patch
|
rail
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
The script.py changes here:
https://github.com/escapewindow/mozharness/compare/master...beagle
This should make the beagle review smoother.
|
Assignee | |
Comment 1•12 years ago
|
||
Sorry, and thanks, about all the reviews.
This patch:
* catches shutil.Error in move()
* updates run_command():
** gets rid of unused parse_at_end (we can use get_output_from_command() with an OutputParser for this)
** updates TODOs
** adds partial_env support, which is less spammy than printing the entire env every time.
** prints env (or partial_env), which we've wanted for a while.
* plus some pep8 changes.
Attachment #786071 -
Flags: review?(rail)
|
||
Updated•12 years ago
|
Attachment #786071 -
Flags: review?(rail) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 786071 [details] [diff] [review]
script
https://hg.mozilla.org/build/mozharness/rev/3a872c4505b4
Attachment #786071 -
Flags: checked-in+
|
|
Assignee | |
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
|
|
||
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•