[Dialer] - The number is blue. Should be white and font weight 300.

RESOLVED FIXED

Status

Firefox OS
Gaia::Dialer
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ivanovpavel, Assigned: ivanovpavel)

Tracking

({polish})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: visual design, visual-tracking)

Attachments

(3 attachments, 2 obsolete attachments)

Created attachment 782236 [details]
proposed patch.html
Attachment #782236 - Flags: review?(sjochimek)
Created attachment 782238 [details]
After patch screenshot
(In reply to Pavel Ivanov [:ivanovpavel] from comment #2)
> Created attachment 782238 [details]
> After patch screenshot

Hey Pavel, did the font size change, cause it's no longer in alignment with the delete arrow?  The colour and weight look good but the font size looks like it got smaller.  Can you check?  Thanks!
Flags: needinfo?(pivanov)
Yep the font size was change ... by mistake I will fix it tonight.
Flags: needinfo?(pivanov)
Attachment #782238 - Attachment is obsolete: true
Created attachment 783276 [details]
After patch screenshot
(In reply to Pavel Ivanov [:ivanovpavel] from comment #5)
> Created attachment 783276 [details]
> After patch screenshot

The font size look right now, but the weight seems off.  Is it 300?
Flags: needinfo?(pivanov)
Yep is 300 but this one is screenshot from desktop (my build on the phone is broken now) but I can give you screenshot from phone tonight.
Flags: needinfo?(pivanov)
Attachment #783276 - Attachment is obsolete: true
Created attachment 785516 [details]
After patch screenshot
Flags: needinfo?(epang)
(In reply to Pavel Ivanov [:ivanovpavel] from comment #8)
> Created attachment 785516 [details]
> After patch screenshot

This looks good now, thanks Pavel!
Flags: needinfo?(epang)

Comment 10

5 years ago
Comment on attachment 782236 [details]
proposed patch.html

landed in master: https://github.com/mozilla-b2g/gaia/commit/e398728c975cf05444f79af9d30f4861279e248c
Attachment #782236 - Flags: review?(sjochimek) → review+

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.