Closed
Bug 898801
Opened 12 years ago
Closed 12 years ago
[Calendar] The size of the add button is not right in calendar list page
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(blocking-b2g:hd+, firefox25 unaffected, b2g18 unaffected, b2g-v1.1hd fixed)
VERIFIED
FIXED
blocking-b2g | hd+ |
Tracking | Status | |
---|---|---|
firefox25 | --- | unaffected |
b2g18 | --- | unaffected |
b2g-v1.1hd | --- | fixed |
People
(Reporter: evanxd, Assigned: evanxd)
Details
Attachments
(7 files, 1 obsolete file)
The size of the add button is not right in calendar list page,
see it in the attachment.
Assignee | ||
Comment 2•12 years ago
|
||
Assignee | ||
Comment 3•12 years ago
|
||
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #782400 -
Attachment is obsolete: true
Assignee | ||
Comment 5•12 years ago
|
||
Hi all,
In the attachments, the add-v1.1.0hd.png image is not the 1.5 times image of the add-v1-train.png image.
They are different images.
I'm asking Amy for that.
Assignee | ||
Comment 6•12 years ago
|
||
Hi all,
For more detail for Comment 5,
skip the size, they are different images.
Comment 7•12 years ago
|
||
Hi,
Can you please tell me where in the device this graphic is being used? Or attach a screenshot?
Thanks
Comment 8•12 years ago
|
||
add-v1.1.0hd.png is the image that should be used (with the drop shadow).
Assignee | ||
Comment 9•12 years ago
|
||
Assignee | ||
Comment 10•12 years ago
|
||
Assignee | ||
Comment 11•12 years ago
|
||
Hi Amy,
In the attachments,
the calendar-master-error7.png is the screenshot in master branch,
and the calendar-hd-error7.png is the screenshot in v1.1.0hd branch.
You could see that, the add button in these two screenshots are different.
Add button in calendar-hd-error7.png is bigger than calendar-master-error7.png.
They should be the same size.
Comment 12•12 years ago
|
||
Hi,
Attached is the corrected size. Please use this version. Thanks!
Assignee | ||
Updated•12 years ago
|
status-b2g-v1.1hd:
--- → affected
Assignee | ||
Updated•12 years ago
|
status-firefox25:
--- → affected
Assignee | ||
Updated•12 years ago
|
status-firefox25:
affected → ---
Assignee | ||
Comment 13•12 years ago
|
||
Hi Rex,
Please help me review the patch.
Thanks. :)
Attachment #784275 -
Flags: review?(rexboy)
Assignee | ||
Updated•12 years ago
|
status-b2g18:
--- → unaffected
status-firefox25:
--- → unaffected
Comment 14•12 years ago
|
||
Comment on attachment 784275 [details]
Pull request
Looks good to me, Thank you!
Attachment #784275 -
Flags: review?(rexboy) → review+
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 15•12 years ago
|
||
Hi Rex,
Thanks. :)
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 16•12 years ago
|
||
Comment 17•12 years ago
|
||
This should land to v1.2 (master) as well as v1.1.0hd branch - please provide a patch for review & uplift.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 18•12 years ago
|
||
Hi lsblakk,
For the master, it is fixed by the patch in Bug 898256.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
![]() |
||
Comment 19•11 years ago
|
||
[2013/10/21 Helix Testing]
Gaia: c829a2042594b6c3a4899ee27979799a0f301534
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019
BuildID 20131015042201
Version 18.0
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•