Closed Bug 898801 Opened 12 years ago Closed 12 years ago

[Calendar] The size of the add button is not right in calendar list page

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

x86
macOS
defect
Not set
normal

Tracking

(blocking-b2g:hd+, firefox25 unaffected, b2g18 unaffected, b2g-v1.1hd fixed)

VERIFIED FIXED
blocking-b2g hd+
Tracking Status
firefox25 --- unaffected
b2g18 --- unaffected
b2g-v1.1hd --- fixed

People

(Reporter: evanxd, Assigned: evanxd)

Details

Attachments

(7 files, 1 obsolete file)

Attached image calendar-hd-error7.png
The size of the add button is not right in calendar list page, see it in the attachment.
HD+ UI bug
blocking-b2g: hd? → hd+
Attached image add-v1.1.0hd.png (obsolete) —
Attached image add-v1-train.png
Attached image add-v1.1.0hd.png
Attachment #782400 - Attachment is obsolete: true
Hi all, In the attachments, the add-v1.1.0hd.png image is not the 1.5 times image of the add-v1-train.png image. They are different images. I'm asking Amy for that.
Hi all, For more detail for Comment 5, skip the size, they are different images.
Hi, Can you please tell me where in the device this graphic is being used? Or attach a screenshot? Thanks
add-v1.1.0hd.png is the image that should be used (with the drop shadow).
Attached image calendar-hd-error7.png
Hi Amy, In the attachments, the calendar-master-error7.png is the screenshot in master branch, and the calendar-hd-error7.png is the screenshot in v1.1.0hd branch. You could see that, the add button in these two screenshots are different. Add button in calendar-hd-error7.png is bigger than calendar-master-error7.png. They should be the same size.
Attached image HeaderIcon_add@1.5.png
Hi, Attached is the corrected size. Please use this version. Thanks!
Attached file Pull request
Hi Rex, Please help me review the patch. Thanks. :)
Attachment #784275 - Flags: review?(rexboy)
Comment on attachment 784275 [details] Pull request Looks good to me, Thank you!
Attachment #784275 - Flags: review?(rexboy) → review+
Hi Rex, Thanks. :)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
This should land to v1.2 (master) as well as v1.1.0hd branch - please provide a patch for review & uplift.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Hi lsblakk, For the master, it is fixed by the patch in Bug 898256.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
[2013/10/21 Helix Testing] Gaia: c829a2042594b6c3a4899ee27979799a0f301534 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019 BuildID 20131015042201 Version 18.0
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: