Closed Bug 898804 Opened 11 years ago Closed 11 years ago

[Calendar] There is a big space area shown in calendar settings page

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:leo+, firefox25 unaffected, b2g18 verified, b2g-v1.1hd fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
firefox25 --- unaffected
b2g18 --- verified
b2g-v1.1hd --- fixed

People

(Reporter: evanxd, Assigned: evanxd)

References

Details

Attachments

(2 files)

calendar-hd-error2.png
41.34 KB, image/png
Details
pull-request.html
362 bytes, text/html
jlal
: review+
Details
Attached image calendar-hd-error2.png — 
There is a big space area shown in calendar settings page,
see it in the attachment.
Depends on: 858463
Triage - agree to leo+ this.
blocking-b2g: leo? → leo+
Assignee: nobody → evanxd
Attached file pull-request.html — 
Hi Gaye,

Please help me review the patch.

And bug is unaffected in master branch, it just for the v1-train branch.
Attachment #782951 - Flags: review?(gaye)
status-b2g-v1.1hd: --- → affected
Hey Evan! I'm a tiny bit overloaded with marionette stuff tonight in preparation for ending the sprint, so let me pass this to lightsofapollo. Looking forward to saying hello at sprint tmw :)!
Attachment #782951 - Flags: review?(gaye) → review?(jlal)
Hi Gaye,

I got it.
Thanks. :)
Hi James,

Could you help here?

Thanks. :)
Flags: needinfo?(jlal)
Attachment #782951 - Flags: review?(jlal) → review+
in master https://github.com/mozilla-b2g/gaia/commit/e00955ce829308b532b3956278ebebe50e91ffbe
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(jlal)
Resolution: --- → FIXED
Evan - there's no commit included here to indicate this landed on v1-train. Did you commit this to v1-train?

Resetting flags until we get confirmation.
status-b2g18: fixed → affected
Hi Jason,

in v1-train: https://github.com/mozilla-b2g/gaia/commit/e00955ce829308b532b3956278ebebe50e91ffbe

Could you check this?

Thanks. :)
Thanks for indicating that. Flipping flag back as such.
status-b2g18: affected → fixed
Hi Jason,

No problem. :)
Verified fixed, the issue no longer reproduces. When no accounts in Calendar Settings, there is no blank space below Calendar Settings and above Personalization.

Environmental Variables
Build ID: 20130805071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a2a9b89ef5ee
Gaia: 45f6a739b09292e16717fb21003386c914ca29c2
Platform Version: 18.1
status-b2g18: fixed → verified
Firmware Version: D300f08o
v1.1.0hd: e00955ce829308b532b3956278ebebe50e91ffbe
v1.1.0hd: 3f5ce9eab0fb2d60d540465b0bb17b88798681e1
status-b2g-v1.1hd: affected → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: