[Calendar] There is a big space area shown in calendar settings page

RESOLVED FIXED

Status

Firefox OS
Gaia::Calendar
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: evanxd, Assigned: evanxd)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(blocking-b2g:leo+, firefox25 unaffected, b2g18 verified, b2g-v1.1hd fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 782207 [details]
calendar-hd-error2.png

There is a big space area shown in calendar settings page,
see it in the attachment.
(Assignee)

Updated

5 years ago
Depends on: 858463
Triage - agree to leo+ this.
blocking-b2g: leo? → leo+
(Assignee)

Updated

5 years ago
Assignee: nobody → evanxd
(Assignee)

Updated

5 years ago
status-b2g18: --- → affected
status-firefox25: --- → unaffected
(Assignee)

Comment 2

5 years ago
Created attachment 782951 [details]
pull-request.html

Hi Gaye,

Please help me review the patch.

And bug is unaffected in master branch, it just for the v1-train branch.
Attachment #782951 - Flags: review?(gaye)
(Assignee)

Updated

5 years ago
status-b2g-v1.1hd: --- → affected
Hey Evan! I'm a tiny bit overloaded with marionette stuff tonight in preparation for ending the sprint, so let me pass this to lightsofapollo. Looking forward to saying hello at sprint tmw :)!
Attachment #782951 - Flags: review?(gaye) → review?(jlal)
(Assignee)

Comment 4

5 years ago
Hi Gaye,

I got it.
Thanks. :)
(Assignee)

Comment 5

5 years ago
Hi James,

Could you help here?

Thanks. :)
Flags: needinfo?(jlal)
Attachment #782951 - Flags: review?(jlal) → review+
in master https://github.com/mozilla-b2g/gaia/commit/e00955ce829308b532b3956278ebebe50e91ffbe
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: needinfo?(jlal)
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
status-b2g18: affected → fixed
Evan - there's no commit included here to indicate this landed on v1-train. Did you commit this to v1-train?

Resetting flags until we get confirmation.
status-b2g18: fixed → affected
(Assignee)

Comment 8

5 years ago
Hi Jason,

in v1-train: https://github.com/mozilla-b2g/gaia/commit/e00955ce829308b532b3956278ebebe50e91ffbe

Could you check this?

Thanks. :)
Thanks for indicating that. Flipping flag back as such.
status-b2g18: affected → fixed
(Assignee)

Comment 10

5 years ago
Hi Jason,

No problem. :)
Verified fixed, the issue no longer reproduces. When no accounts in Calendar Settings, there is no blank space below Calendar Settings and above Personalization.

Environmental Variables
Build ID: 20130805071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a2a9b89ef5ee
Gaia: 45f6a739b09292e16717fb21003386c914ca29c2
Platform Version: 18.1
status-b2g18: fixed → verified
Firmware Version: D300f08o
v1.1.0hd: e00955ce829308b532b3956278ebebe50e91ffbe
v1.1.0hd: 3f5ce9eab0fb2d60d540465b0bb17b88798681e1
status-b2g-v1.1hd: affected → fixed
You need to log in before you can comment on or make changes to this bug.