Closed Bug 898812 Opened 9 years ago Closed 9 years ago

Add support for 4.3's dhcp_do_request

Categories

(Firefox OS Graveyard :: Wifi, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(1 file, 1 obsolete file)

4.3 has a new dhcp_do_request. It also brings back dhcp_do_request_renew.

The new dhcp_do_request takes an array of pointers to dns addresses. It also reports the domain. Note that the new domain arg isn't specified at http://androidxref.com/4.3_r2.1/xref/system/core/include/netutils/dhcp.h#26 , but it really is implemented that way - http://androidxref.com/4.3_r2.1/xref/system/core/libnetutils/dhcp_utils.c#172 . Android itself doesn't have problems with the wrong dhcp.h because it doesn't use it -  http://androidxref.com/4.3_r2.1/xref/frameworks/base/core/jni/android_net_NetUtils.cpp#26 .
This is getting pretty messy. We should just nuke GB and JB-MR1 support in a follow up, I think.
Attachment #782215 - Flags: review?(vchang)
Attachment #782215 - Flags: review?(vchang) → review+
I accidentally reversed the other patch..
Attachment #782215 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/9726ea53fed6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.