898812 - Add support for 4.3's dhcp_do_request

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Michael Wu [:mwu]]

4.3 has a new dhcp_do_request. It also brings back dhcp_do_request_renew.

The new dhcp_do_request takes an array of pointers to dns addresses. It also reports the domain. Note that the new domain arg isn't specified at http://androidxref.com/4.3_r2.1/xref/system/core/include/netutils/dhcp.h#26 , but it really is implemented that way - http://androidxref.com/4.3_r2.1/xref/system/core/libnetutils/dhcp_utils.c#172 . Android itself doesn't have problems with the wrong dhcp.h because it doesn't use it -  http://androidxref.com/4.3_r2.1/xref/frameworks/base/core/jni/android_net_NetUtils.cpp#26 .

Comment 1

[Michael Wu [:mwu]]

Attachment: Support dhcp_do_request in JB MR2

This is getting pretty messy. We should just nuke GB and JB-MR1 support in a follow up, I think.

Comment 2

[Michael Wu [:mwu]]

Attachment: Support dhcp_do_request in JB MR2, v2

I accidentally reversed the other patch..

Comment 3

[Michael Wu [:mwu]]

https://hg.mozilla.org/projects/birch/rev/9726ea53fed6

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9726ea53fed6