898875 - [Australis] The Private Browsing Indicator is too close to the OSX Window Fullscreen Button

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Mehmet]

Attachment: screenshot.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130725195523

Steps to reproduce:

1. Run latest UX Build on OSX 10.8.4
2. Open a Private Mode window
3. Take a look at the Private Browsing Indicator and the Window Fullscreen Button in the right top corner


Actual results:

The Private Browsing Indicator is too close to the Window Fullscreen Button


Expected results:

There should be a little bit more space between the two icons.

A screenshot is attached.

Comment 1

[Mehmet]

Ping?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Do you think this could be a good-first-bug? (I saw you fixed bug 898875.)

Comment 3

[Matthew N. [:MattN]]

Not really since it's hard to get right with 10.6 and the rest. I'm not even sure if we need to make a change and what the change would be. The original patch got UI review so I don't think we need a major change. Now that bug 851652 landed, the controls should be moved by the same amount as the fullscreen button did.

Comment 4

[Matthew N. [:MattN]]

Attachment: Screenshot of regression from bug 851652

Comment 5

[Mike Conley (:mconley) (:⚙️)]

I believe this was fixed in bug 973694 - the distance between the private browsing indicator and the fullscreen button is now equal to the distance between the fullscreen button and the edge of the window.