898881 - OpenSearch autodiscovery disabled in Private Browsing Mode

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Lachlan]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20100101 Firefox/17.0 (Beta/Release)
Build ID: 20130618114625

Steps to reproduce:

Enter Private Browsing Mode. Navigate to a site (ex: http://fr.wikipedia.org/) with an opensearch plugin using a link rel=search tag. Click Firefox search drop-down menu.


Actual results:

There is no option to add the search plugin.


Expected results:

There should be an option to add the search plugin.

Comment 1

[Josh Matthews [:jdm]]

Huh, reading code like rebuildPopupDynamic (http://mxr.mozilla.org/mozilla-central/source/browser/components/search/content/search.xml#307), I can't see why this would not be appearing.

Comment 2

[Josh Matthews [:jdm]]

Aha: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#3013

Comment 3

[Josh Matthews [:jdm]]

Ehsan, is there any reason we should restrict adding opensearch plugins in private windows?

Comment 4

[(no longer active)]

Yes, this was done in bug 577685.

Comment 5

[Lachlan]

I was unaware of bug 577685. It appears to be in conflict with the final comments of bug 566010. Specifically, other permanent modifications to Firefox are permitted, e.g. bookmarks, add-ons, browser upgrades. Also, I can add a search plugin using javascript from within a web page (e.g. Mycroft).

Considering that functionality is permitted, can we re-enable the auto-discovery of search engines in Private Browsing mode?

Comment 6

[(no longer active)]

I don't feel very strongly about this.  What about you, Gavin?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

The restriction does seem pretty arbitrary, and I don't see any reason to differ from the bookmarks behavior, so I think we should remove it.

Comment 8

[(no longer active)]

Attachment: Patch (v1)

Comment 9

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ded8c8339686

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ded8c8339686